Skip to content

Suggestion: Don't collect code coverage from registerServiceWorker.js File #2507

Closed

Description

@wirmar

Currently coverage is collected for the registerServiceWorker.js File by default. However this code was not user generated. Maybe this File should be ignored by default? ("collectCoverageFrom": ["src/**/*.{js,jsx}", "!**/registerServiceWorker.js"])

Activity

  1. gaearon commented on Jun 22, 2017

    @gaearon
    Contributor

    I don't know. I think it's a slippery slope: src/index.js was also generated and also not covered. And I think it's fine. Chasing 100% coverage is usually a misleading goal, and I don't want to give people the feeling that we encourage that.

  2. locked and limited conversation to collaborators on Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions