Skip to content

Port cra.sh development task to javascript #2280

Closed

Description

@ianschmitz

A quick improvement I'd thought I'd propose for those of us looking to contribute to CRA from a Windows machine.

As part of end to end testing while contributing to CRA we can use the npm run create-react-app my-app command to generate a new app. However this fails when run on Windows:

$ npm run create-react-app test

> @ create-react-app C:\Projects\create-react-app
> tasks/cra.sh "test"

'tasks' is not recognized as an internal or external command,
operable program or batch file.

A simple solution may be to port the cra.sh shell script to javascript, which would make it easier to run on a Windows based machine. There are workarounds such as installing Bash on Windows 10, but this would make life a little easier :)

I'd be happy to submit a PR if we think it's worthwhile.

Activity

  1. gaearon commented on May 20, 2017

    @gaearon
    Contributor

    Please do!

  2. ianschmitz commented on Jul 29, 2017

    @ianschmitz
    ContributorAuthor

    Closing as this issue has been aggregated over at #2855.

  3. locked and limited conversation to collaborators on Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions