Repository navigation
visual studio code eslint support #1955
Description
Description
The docs here https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md mention that vs code should support the eslint config without doing anything extra
VS Code ESLint plugin automatically detects Create React App's configuration file. So you do not need to create eslintrc.json at the root directory, except when you want to add your own rules. In that case, you should include CRA's config by adding this line:
in practice, with latest versions of everything, i still had to add .eslintrc containing { "extends": "react-app" } in order for the editor to load a config
Expected behavior
VS Code ESLint plugin automatically detects Create React App's configuration file
Actual behavior
VS Code ESLint plugin needs and .eslintrc file to detect any config
Environment
Run these commands in the project folder and fill in their results:
npm ls react-scripts
└── react-scripts@0.9.5
node -v
v7.8.0
npm -v
4.2.0
- Operating system:
macOS
I am not sure if this is a bug or a lack in documentation or I m just doing something wrong.
If it's the docs i can make a pull request I guess
Cheers
Activity
Timer commentedon Apr 15, 2017
Can we trace this down to any specific VSCode version when this stopped working (I haven't tested this myself)? It may be a regression on their end.
Otherwise, we may need to update the documentation to reflect this change.
anilreddykatta commentedon Apr 19, 2017
@tzapu
vscodedoesn't seem to detecteslintconfiguration for apps created usingcreate-react-app.I have observed similar behavior in
vscode-1.11.2tzapu commentedon Apr 20, 2017
@Timer @anilreddykatta i noticed this on Version 1.11.1 (1.11.1)
so so far, 1.11.1 & 1.11.2 seem not to be working
cheers
Angarsk8 commentedon Apr 24, 2017
Not working here neither, I'm on version 1.11.2.
dbaeumer commentedon Apr 27, 2017
Hi, I maintain the ESLint extension for VS Code and got here due to microsoft/vscode-eslint#230.
I created a react app using
create-react-app my-appand the generated package.json file doesn't contain aneslintConfigproperty. After addingthings started to work for me. Is there something I am missing ?
tzapu commentedon Apr 27, 2017
i think the confusing bit is that the docs are saying that it just works, you don't need to add anything, as the eslint extension in vscode auto detects create react app's eslint rules
hope this helps
cheers
dbaeumer commentedon Apr 28, 2017
To make setup for users easier could the
create-react-appgenerate a corresponding.eslintrc. From all feedback I got it is easier for users to deal with an.eslintrcfile than a property in thepackage.jsonfile.gaearon commentedon May 1, 2017
I don’t think we’ll be creating
.eslintrcin the project folder, no. A property inpackage.jsonis a supported way to configure ESLint, so we would like to keep using that.luftywiranda13 commentedon May 1, 2017
@gaearon
just for a clear clarification
eslintConfigin package.json is just a way to customize eslint in code editor but has nothing to do with eslint warning/error in browser/cli, right?gaearon commentedon May 1, 2017
Yes. In the browser/cli, we hardcode ESLint to use the
react-appconfiguration. However IDEs can’t know about this.I think it’s fine if we encourage people to create
.eslintrcin their project folder if that solves the problem for VSCode. I’m just saying we won’t be generating it by default.gaearon commentedon May 1, 2017
Does this solve the issue?
Can somebody review this PR please?
#2054
tzapu commentedon May 1, 2017
this seems like satisfactory solution, it's clear enough, it works, all is good in the world again.
thank you very much
gaearon commentedon May 1, 2017
Sounds great. Sorry for the trouble. 😛
vladbilyk commentedon Jul 18, 2017
I've tried both things (
.eslintrcin the root andeslintConfiginpackages.config) but with the same result: "Cannot find module 'eslint-config-react-app' Referenced from:". New react app, VSC 1.14.1...allstone commentedon Nov 28, 2017
adding eslintConfig to package.json works for me
Add eslint config line
Add foundational stuff