Skip to content

Show a transparent overlay with development warnings #1888

Open

Description

@Timer

As proposed here, maybe we should have a transparent "warning overlay" which is dismiss-able.

Activity

  1. added this to the milestone on Mar 26, 2017
  2. hamxabaig commented on Apr 25, 2017

    @hamxabaig

    It'll show in the website the user is developing @Timer ? If yes, a full screen overlay shows every time when there are warnings ?

  3. Timer commented on Apr 25, 2017

    @Timer
    ContributorAuthor

    Warnings won't take over the screen like an error.

    The idea is to make less-intrusive version of the crash overlay which appears for runtime warnings, and maybe compile warnings.

    Basically, only when in development mode, there would be a small pop-up on screen (which is unobtrusive). Hovering it would display more context and clicking would "pop" it into a full screen overlay like crash overlay.

    Think toastr.

  4. hamxabaig commented on Apr 25, 2017

    @hamxabaig

    Cool, Okay 👍

  5. gaearon commented on May 8, 2017

    @gaearon
    Contributor

    I would hold off implementing this because we might want to build something like this into React itself. @bvaughn experimented with it. It’s going to be confusing if these efforts are not aligned.

  6. modified the milestones: , on May 8, 2017
  7. viankakrisna commented on Jul 12, 2017

    @viankakrisna
    Contributor

    @bvaughn @gaearon any update on the warnings? I've got my hands free and build this for CRA's lint warning.

    jul-13-2017 03-20-34

  8. bvaughn commented on Jul 12, 2017

    @bvaughn
    Contributor

    Nothing yet on our end, @viankakrisna, although I plan to pick it back up soon.
    Your overlay looks nice! 😄

  9. viankakrisna commented on Jul 12, 2017

    @viankakrisna
    Contributor

    Thanks! sent a PR 😄 IIRC the React ones gonna be about React's own warning right?

  10. bvaughn commented on Jul 12, 2017

    @bvaughn
    Contributor

    Depends. We haven't decided yet what the error/warning API will look like for 16. Would be nice if CRA (and maybe other 3rd party libs) could piggy-back on React's warning system.

  11. viankakrisna commented on Jul 12, 2017

    @viankakrisna
    Contributor

    Ok, I'll leave it to the maintainers about my overlay then. Excited to see how it will be implemented though :)

  12. swyxio commented on Jul 19, 2018

    @swyxio
    Contributor

    We have exposed frames for react 16 warnings in react/react#13242 and react-error-overlay can now take advantage of them in a future rewrite

  13. modified the milestones: 2.0.x, 2.x on Sep 26, 2018
  14. removed this from the 2.x milestone on Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions