Skip to content

Don’t break words apart in the error box #1853

Closed
#1842
Closed
Don’t break words apart in the error box#1853
#1842
Labels
tag: enhancement
Milestone
1.0.0

Description

@gaearon
gaearon
opened on Mar 18, 2017

Just noticed the error box is breaking words apart (e.g. "s/newline/tring").
This should not happen.

screen shot 2017-03-18 at 15 32 41

I also don’t think the error text should be monospace. Makes it a bit hard to read.

Activity

  1. gaearon
    added
    tag: enhancement
    on Mar 18, 2017
  2. gaearon
    added this to the milestone on Mar 18, 2017

  3. Timer commented on Mar 18, 2017

    @Timer
    Timer
    on Mar 18, 2017
    Contributor

    Another thing I noticed is that the app's CSS influences the overlay, so we should look into preventing that (e.g. bootstrap).
    Would an iframe accomplish this?

  4. gaearon commented on Mar 18, 2017

    @gaearon
    gaearon
    on Mar 18, 2017
    ContributorAuthor

    Yea, iframe would do the trick (the reason I used iframe for syntax error overlay).

  5. Timer
    closed this as completedin #1842on Apr 25, 2017
  6. lock
    locked and limited conversation to collaborators on Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tag: enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions