You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
offline support with yarn says it's offline while yarn isn't #1818
On a Ubuntu 17.0.4 box, with yarn version 0.21.3 and create-react-app 1.3 on one laptop where yarn successfully can install from online sources, create-react-app insists on thinking it's offline and won't install. A downgrade to 1.1.0 (before this offline feature was added) fixed this issue.
I'll note that other Linux machines on the same local network didn't display this problem. And yarn did work just fine on the machine where create-react-app thought it was online.
And do both result int false when offline?
Sounds like he might have a DNS configuration error, but if this is something we can make more reliable, I'm all for it.
@kdleijer is very new at this whole toolchain (in fact I was giving a React training when this happened on his machine) so a PR may be a bridge too far. I could do a PR with him but it'll have to be next week.
Is this just about changing the one line to lookup? It doesn't look like much automatic testing is possible for this change, but we can test whether it fixes the issue for him manually (if we can still replicate his firewall issue).
Ok, @kdleijer and I will look at this when we can sit down together Monday. Thanks for the quick and constructive feedback, it's very much appreciated!
Activity
Timer commentedon Mar 14, 2017
Can you
dig registry.yarnpkg.com(dig/host/ping) and post the output?If all seems well, can you run this snippet in the node REPL and see what
erris?kdleijer commentedon Mar 15, 2017
Output of dig;
output of ping;
faassen commentedon Mar 15, 2017
I'll note that other Linux machines on the same local network didn't display this problem. And yarn did work just fine on the machine where create-react-app thought it was online.
Timer commentedon Mar 15, 2017
Can one of you please test https://github.com/facebookincubator/create-react-app/blob/master/packages/create-react-app/createReactApp.js#L519 and then switch it to
lookupafter and see if it fixes it?faassen commentedon Mar 16, 2017
We tried the following snippet:
The output on my (working) machine is:
But on @kdleijer machine with the problem it's:
Timer commentedon Mar 16, 2017
And do both result int false when offline?
Sounds like he might have a DNS configuration error, but if this is something we can make more reliable, I'm all for it.
kdleijer commentedon Mar 16, 2017
Hi Timer
Yes both are false when completely offline with Ubuntu.
For DNS configuration I have;
Timer commentedon Mar 16, 2017
@kdleijer You can look into this or this to fix the DNS -- most likely a firewall issue (does it work for other sites?).
@gaearon think we can switch this to
lookup? I see no harm if it's more reliable.gaearon commentedon Mar 16, 2017
Sure, happy to switch.
kdleijer commentedon Mar 16, 2017
Tried all, with different results;
It might indeed seems like a DNS-issue,a although create-react-app@1.1.0 does work
Timer commentedon Mar 16, 2017
The older create-react-app works because this is a new feature.
Would you like to send a PR switching us to
lookup?I would try adding google's DNS (
8.8.8.8&8.8.4.4) to your conf file.faassen commentedon Mar 16, 2017
@kdleijer is very new at this whole toolchain (in fact I was giving a React training when this happened on his machine) so a PR may be a bridge too far. I could do a PR with him but it'll have to be next week.
Is this just about changing the one line to
lookup? It doesn't look like much automatic testing is possible for this change, but we can test whether it fixes the issue for him manually (if we can still replicate his firewall issue).Timer commentedon Mar 16, 2017
Yeah, it's just that one line change. 😄 You can even edit the file on GitHub.
faassen commentedon Mar 16, 2017
Okay, we'll see whether @kdleijer wants to do it! We can say it's part of the training. :)
faassen commentedon Mar 16, 2017
Ok, @kdleijer and I will look at this when we can sit down together Monday. Thanks for the quick and constructive feedback, it's very much appreciated!
Timer commentedon Mar 16, 2017
No problem, thank you for being responsive!
Changed resolve into lookup
Check internet connectivity with lookup instead of resolve (#1863)
Merge upstream changes from create-react-app 0.9.x (#84)
Merge upstream create-react-app v1.0.7 (#90)
Check internet connectivity with lookup instead of resolve (react#1863)
Check internet connectivity with lookup instead of resolve (react#1863)