Repository navigation
Code style update (const, arrow functions) #1731
Description
Started here - #1433 (comment)
(only for packages/react-scripts)
- If arrow functions are already used maybe switch others functions to arrow ?
- Same for
var->const. For example:- test.js - only
constis used - start.js - only
varis used - webpack.config.prod.js both
varandconstare used
- test.js - only
Activity
gaearon commentedon Mar 6, 2017
Let's do what I suggested there for global CLI too, and move all the code except the Node version check into a separate file that would be lazily required. This way we can use modern syntax there without screwing up the version check message.
tuchk4 commentedon Mar 6, 2017
vartoconstindex.jswith node version check that should be available for node 0.12 andcreate-react-app.js(suggest your script name) with modern syntax that is required fromindex.jsafter node version checkcorrect?
gaearon commentedon Mar 6, 2017
Yes, although I'd only switch to arrows where it helps readability. I'd leave top level functions as named declarations.