create-react-app does not clean up directory after failed install on Windows #1671

Activity

1. Timer

   added

   issue: bug

   contributions: up for grabs!

   on Feb 27, 2017
2. johann-sonntagbauer commented on Feb 28, 2017

   

   johann-sonntagbauer

   on Feb 28, 2017

   Contributor

   More actions

   I can take a look at that one (windows user :) )
3. johann-sonntagbauer commented on Feb 28, 2017

   

   johann-sonntagbauer

   on Feb 28, 2017

   Last edited by johann-sonntagbauer

   Contributor

   More actions

   first intention was right. On windows the create-react-app process is currently locking the directory and therefor the deletion operation will not perform anything.
   Simple fix would be to introduce a process.chdir(path.resolve(root, '..')); before the fs.removeSync(path.join(root));

   kinda ugly but works
4. Timer

   removed

   contributions: up for grabs!

   on Feb 28, 2017
5. Timer commented on Feb 28, 2017

   

   Timer

   on Feb 28, 2017

   ContributorAuthor

   More actions

   Not ugly, thanks!
6. Timer

   closed this as completedon Feb 28, 2017
7. gaearon

   added this to the 0.9.3 milestone on Feb 28, 2017
8. lock

   locked and limited conversation to collaborators on Jan 22, 2019