Repository navigation
Bugs in extract-text-webpack-plugin #1668
Description
-
blocking
- import() & System.import (duplicate?)
These issues seem to break code that relies onimport()andrequires css, which we now support. I have not tested this, but concerning nevertheless.
- import() & System.import (duplicate?)
-
would be nice
Activity
gaearon commentedon Feb 27, 2017
Only related to WP2? Not for 0.9 branch?
Timer commentedon Feb 27, 2017
Only related to webpack-2 afaik, issues are tagged so and are related to wp2 features.
gaearon commentedon Apr 18, 2017
This is worrying me. I need to start working on integrating the PWA stuff, and it seems like we'd have to backport it to 0.9.x since Webpack 2 is not ready 😞
Timer commentedon Apr 18, 2017
I believe this never worked in WP 1 (with
require.ensure), I see some older issues mentioningrequire.ensure.If we don't enable performance hints (yet) we won't be bugging people to move to
import(), and thus not in a worse position.Timer commentedon Apr 18, 2017
Full disclosure I haven't actually tested these issues to see if they're present, but since they're open, tagged, and +1'd I assume they're valid.
gaearon commentedon Apr 19, 2017
OK I think we can live with this.
gaearon commentedon Apr 19, 2017
At least webpack-contrib/extract-text-webpack-plugin#188 only happens in watch mode so it doesn’t affect us.
joshwiens commentedon May 5, 2017
@Timer / @gaearon - Anything like this where you have blocking / aggravating bugs with something living under
webpack-contribtag me directly or@webpack-contrib/org-maintainersso we can get them on the high priority list and addressed.Timer commentedon May 5, 2017
Thanks for letting us know @d3viant0ne, we would love to see webpack-contrib/extract-text-webpack-plugin#406 fixed especially if we're going to turn on performance hints.
joshwiens commentedon Jun 11, 2017
@Timer - On the off chance you haven't seen it, @sokra is attacking the performance problem at it's source as opposed to trying to stick a bandaid on ExtractText.
https://medium.com/webpack/the-new-css-workflow-step-1-79583bd107d7
More info as it becomes available :)
gaearon commentedon Jan 8, 2018
Closing as stale. (Blockers have since been fixed.)