Repository navigation
PORT env variable not always an integer #1584
Description
Description
When setting the PORT env variable it is a string, no matter if I set it like PORT="8088" or PORT=8088. This causes the port check in the start script if (port === DEFAULT_PORT) to always fail. port is an integer and DEFAULT_PORT a string. It also causes the kitchensink e2e test to hang.
Expected behavior
The server should start at the given port.
Actual behavior
The start script complains that something is already running on the given port.
Environment
Run these commands in the project folder and fill in their results:
npm ls react-scripts(if you haven’t ejected): react-scripts@0.9.0node -v: v6.9.4npm -v: 3.10.10
Then, specify:
- Operating system: macOS 10.12.3
- Browser and version: is not a browser issue
Reproducible Demo
Try starting the development server with PORT=3002 npm start
Activity
Timer commentedon Feb 18, 2017
Hmm, odd. I can't reproduce using
.envor the command line. Thanks for the report, nevertheless!matoilic commentedon Feb 18, 2017
I've retested it on other machines and the only one I can reproduce it on is again a Mac (El Capitan) with Bash. When using other shells or operating systems the PORT env variable is already an integer without converting it previously.
fixes react#1584 PORT env variable not always an integer (react#1585)
fixes react#1584 PORT env variable not always an integer (react#1585)
fixes #1584 PORT env variable not always an integer (#1585)
fixes react#1584 PORT env variable not always an integer (react#1585)
fixes react#1584 PORT env variable not always an integer (react#1585)
Merge upstream changes from create-react-app 0.9.x (#84)
fixes react#1584 PORT env variable not always an integer (react#1585)
fixes react#1584 PORT env variable not always an integer (react#1585)