Repository navigation
npm run build silently fails on OOM #1493
Description
Description
When running npm run build, if the system runs out of memory...
Expected behavior
It should exit with a non-zero return code.
Actual behavior
The process exits return code 0.
Environment
npm ls react-scripts: 0.7.0node -v: v6.9.5npm -v: 3.10.10
Then, specify:
- Operating system: Ubuntu 16.04
- Browser and version: n/a
Reproducible Demo
Try building on a tiny VM.
See #1026
Activity
gaearon commentedon Feb 7, 2017
Agreed it’s an issue, do you have any idea how to solve this?
brandones commentedon Feb 7, 2017
Well, it looks like
react-scripts buildrunsnode build.js, and when you send SIGTERM to the latter process (as happens with an OOM) it exits silently. Default behavior for node on SIGTERM (aka signal 15) is to exit 15. So this script is probably catching SIGTERM somewhere and exiting "gracefully."brandones commentedon Feb 7, 2017
Adding
to the end of
react-scripts/scripts/build.jsfixes the problem. I'll add a couple more signals, console.log an error message, and submit a pull request -- cool? Is there a cleanup hook I should call?gaearon commentedon Feb 7, 2017
@brandones Sounds great, thanks!
Make build exit with error code when interrupted
Make build exit with error code when interrupted (#1496)
gaearon commentedon Feb 11, 2017
Can we consider this resolved by #1496?
gaearon commentedon Feb 11, 2017
Going to close in hope it’s resolved but please reopen if not.
Make build exit with error code when interrupted (react#1496)
Make build exit with error code when interrupted (react#1496)
Make build exit with error code when interrupted (react#1496)
Make build exit with error code when interrupted (react#1496)
Merge upstream changes from create-react-app 0.9.x (#84)