Feature: Support querystring on npm start #1450

Activity

1. gaearon

   added

   issue: proposal

   on Feb 9, 2017
2. gaearon commented on Feb 9, 2017

   

   gaearon

   on Feb 9, 2017

   Contributor

   More actions

   Hmm. Why not set up a redirect in src/index.js if this is absolutely required for the app?
3. coryhouse commented on Feb 9, 2017

   

   coryhouse

   on Feb 9, 2017

   ContributorAuthor

   More actions

   Interesting. I hadn't considered that. The only downsides I see:

   1. It's harder to find. Start would be the logical place I'd check first.
   2. It would bubble up to all environments which is typically undesirable. Though this can be mitigated by checking the url for localhost so that redirecting only occurs in local dev.

   The use case: App that is normally called from a separate app with required context provided via querystring.

   I have the config above working on a fork of create-react-app, but I had to disable the Apple specific alternative to opn in react-dev-utils/openBrowser because it ignores querystrings.
4. gaearon commented on Feb 9, 2017

   

   gaearon

   on Feb 9, 2017

   Contributor

   More actions

   I think this is a bit of an unusual use case, and I don't think we'll be supporting this by default.
   Maybe in the future as part of more general "default URL" customization.
5. gaearon commented on Feb 11, 2017

   

   gaearon

   on Feb 11, 2017

   Last edited by gaearon

   Contributor

   More actions

   I think I'm going to close this unless there's more support for this being configurable. Since 0.9.0, you can override BROWSER environment variable to disable the default opening behavior (and potentially do something else in a custom script instead):

     "start": "BROWSER=none npm start && node scripts/myOpen.js"
6. gaearon

   closed this as completedon Feb 11, 2017
7. gaearon commented on May 15, 2017

   

   gaearon

   on May 15, 2017

   Contributor

   More actions

   Seems like this use case will be fixed by #1590.
8. lock

   locked and limited conversation to collaborators on Jan 21, 2019