You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I checked the last commit (which was a while ago) and it passed all commit checks:
Now, if I do clean setup, clone the repo and try to build it, it fails. The only thing that might have changed during this time are dependencies (semantic updates).
Adding babel-runtime to my dependencies fixes this issue but I'm not sure if this is the right way to go about it?
I'm seeing this issue in a different setup.
Since npm install is not deterministic, I'm thinking that babel-runtime
ends up differently in the node_modules hierarchy and surfaces a problem
with a dependency's package.json.
Maybe some module (semantic-ui-react judging by first post's CI log) that depends on it forgets to declare a dependency. In this case whether the dependency exists or not depends on other project dependencies and is non-deterministic. Have you raised an issue with the library causing this, like semantic-ui-react?
Activity
[-]Issues with missing babel-runtime[/-][+]Cannot resolve module 'babel-runtime/*'[/+]gaearon commentedon Feb 9, 2017
This is weird. Is it still reproducible? Can you provide exact instructions to reproduce it?
scholtzm commentedon Feb 9, 2017
I'll test this out again in the next day or two.
scholtzm commentedon Feb 9, 2017
@gaearon I just removed babel-runtime and it builds now without it. Not sure what exactly was the issue but I guess we can close this now.
🤔
gaearon commentedon Feb 9, 2017
Sometimes it's healthier not to know.
andreineculau commentedon Feb 9, 2017
gaearon commentedon Feb 9, 2017
Maybe some module (
semantic-ui-reactjudging by first post's CI log) that depends on it forgets to declare a dependency. In this case whether the dependency exists or not depends on other project dependencies and is non-deterministic. Have you raised an issue with the library causing this, likesemantic-ui-react?levithomason commentedon Feb 11, 2017
This is fixed in
semantic-ui-react@0.64.8.gaearon commentedon Feb 11, 2017
Awesome, thanks for reporting back.