Skip to content

RFC: Support for eslint-plugin-compat #1345

Open

Description

@amilajack

Recently I've been working on an eslint plugin called eslint-plugin-compat that lints support for API's by using the caniuse db. It seems there is demand from the community for this plugin. Wonder if it has a place in create-react-app. Would a PR for it be welcome?

Here's a demo of it in action

demo of plugin usage

Also planning to add integration with babel-preset-env and browserlist

Activity

  1. gaearon commented on Feb 11, 2017

    @gaearon
    Contributor

    That's pretty cool. Let's take another look at this after #1249.

  2. amilajack commented on Feb 11, 2017

    @amilajack
    Author

    Great! This actually works with the browserslist config in the package.json 🎉

    https://github.com/amilajack/eslint-plugin-compat-demo/blob/master/package.json#L9

  3. added this to the milestone on Jan 8, 2018
  4. gaearon commented on Jan 20, 2018

    @gaearon
    Contributor

    Do you want to send a PR for this?

  5. amilajack commented on Jan 20, 2018

    @amilajack
    Author

    Sure! I don't know how CRA internals work. Which .eslintrc should I change?

  6. amilajack commented on Jan 20, 2018

    @amilajack
    Author

    Thanks. I'll start working on this

  7. Timer commented on Jan 22, 2018

    @Timer
    Contributor

    How would polyfills work in something like CRA? Excited to see your PR.

  8. stereobooster commented on Apr 17, 2018

    @stereobooster
    Contributor
  9. modified the milestones: 2.0.x, 2.x on Sep 26, 2018
  10. removed this from the 2.x milestone on Nov 2, 2018
  11. ackvf commented on Apr 5, 2019

    @ackvf

    Is there a way how to use this with create-react-app 2.0 nowadays?

  12. morsdyce commented on May 19, 2020

    @morsdyce

    Is this being worked on? Can I open a PR for this?

  13. amilajack commented on May 20, 2020

    @amilajack
    Author

    I wanted to wait to implement better polyfill and babel interoperability to the plugin before making a PR for this. I'll respond here again once I've implemented it.

  14. amilajack commented on Jun 28, 2020

    @amilajack
    Author

    How would polyfills work in something like CRA? Excited to see your PR.

    It detects if you're using babel or TS and if you are, it assumes all ES APIs are polyfilled and lints only WebAPIs

  15. amilajack commented on Jun 28, 2020

    @amilajack
    Author

    I wanted to wait to implement better polyfill and babel interoperability to the plugin before making a PR for this. I'll respond here again once I've implemented it.

    @morsdyce The plugin should be good to implement now!

  16. jakobvase commented on Sep 30, 2020

    @jakobvase

    @gaearon You last wrote on this 2 years ago. Would you still accept a PR for this? Or is CRA headed in another direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions