Install react-scripts, react, and react-dom at the same time #1239

Activity

1. gaearon

   added

   enhancement

   contributions: up for grabs!

   on Dec 11, 2016
2. fson commented on Dec 12, 2016

   

   fson

   on Dec 12, 2016

   Last edited by fson

   Contributor

   More actions

   I think the tradeoff here is that installing them at once requires create-react-app to know which dependencies to install. create-react-app is a stable package that should only rarely update.

   That said, maybe it is reasonable to assume that we'll always want at least react and react-dom. (Unless the same create-react-app command is used with, say, create-elm-app using the --scripts-version option, which is a use case we don't officially support I guess?) If a future version of react-scripts needs to add more packages, it can still do so, and won't be any worse off than the current situation is with 2 installs ¯\(ツ)/¯
3. gaearon commented on Dec 12, 2016

   

   gaearon

   on Dec 12, 2016

   Last edited by gaearon

   ContributorAuthor

   More actions

   That said, maybe it is reasonable to assume that we'll always want at least react and react-dom

   I think this is a reasonable assumption.
   If you're using a fork not for React, you might as well fork create-react-app CLI since the name would lie.

   👍React with 👍2Reacted by Ville Immonen and Jack McCalley
4. djgrant commented on Jan 13, 2017

   

   djgrant

   on Jan 13, 2017

   Contributor

   More actions

   Presently you can fork react-scripts to create react apps (using create-react-app --scripts-version=my-react-scripts) that use preact or some other compatible library.

   It would be good to keep create-react-app CLI agnostic in this way.
5. gaearon commented on Jan 13, 2017

   

   gaearon

   on Jan 13, 2017

   ContributorAuthor

   More actions

   It would be nice but we can’t promise we won’t add some React-specific features in the future.
6. gaearon

   added this to the 0.9.1 milestone on Feb 11, 2017
7. Timer

   removed

   contributions: up for grabs!

   on Feb 23, 2017
8. Timer

   closed this as completedin #1253on Feb 23, 2017
9. Timer

   added 2 commits that reference this issue on Feb 23, 2017

   Install react, react-dom, and react-scripts at the same time (#1253)

   ...

   This issue will close once commit a82896c is merged into the 'main' branch.

   a82896c

   Install react, react-dom, and react-scripts at the same time (#1253)

   ...

   This issue will close once commit 7c4c167 is merged into the 'main' branch.

   7c4c167
10. kst404

    added a commit that references this issue on Mar 2, 2017

    Install react, react-dom, and react-scripts at the same time (react#1253

    ...

    This issue will close once commit 9d27500 is merged into the 'master' branch.

    9d27500
11. SpaceK33z

    added a commit that references this issue on Mar 7, 2017

    Install react, react-dom, and react-scripts at the same time (react#1253

    ...

    This issue will close once commit 5209339 is merged into the 'master' branch.

    5209339
12. randycoulman

    added a commit that references this issue on May 8, 2017

    Install react, react-dom, and react-scripts at the same time (react#1253

    ...

    This issue will close once commit 601653d is merged into the 'zeal' branch.

    601653d
13. iamlacroix

    added a commit that references this issue on May 16, 2017

    Merge upstream changes from create-react-app 0.9.x (#84)

    ...

    This issue will close once commit 7a11edd is merged into the 'master' branch.

    7a11edd
14. lock

    locked and limited conversation to collaborators on Jan 22, 2019
15. Pong420

    added a commit that references this issue on Feb 24, 2019

    Install react, react-dom, and react-scripts at the same time (react#1253

    ...

    This issue will close once commit 5c2acc9 is merged into the 'master' branch.

    5c2acc9
16. LishuGupta652

    added a commit that references this issue on Oct 8, 2024

    Install react, react-dom, and react-scripts at the same time (react#1253

    ...

    This issue will close once commit f7a3b3c is merged into the 'master' branch.

    f7a3b3c