Repository navigation
Disable watch in npm test -- --coverage #1207
Description
See discussion in jestjs/jest#2256.
We need to decide how to handle this and fix it.
See discussion in jestjs/jest#2256.
We need to decide how to handle this and fix it.
Activity
BenoitAverty commentedon Dec 9, 2016
My opinion on this is that the coverage information is usually not needed at the same time as when the watch mode is most useful.
Most of the time, I use watch mode while writing tests or doing tdd, which allow me to go faster than if I had to run the tests all the time. In this case, I usually don't care about test coverage.
On the other hand, right before commiting, I find the coverage info very useful because it allows me to see if I forgot a test or if something I thought I tested is, in fact, not properly done. When I notice that, I often fix it without watch mode.
I don't know if there are a lot of people in my case, but for me the simplest and best option is to simply disable watch mode when the --coverage flag is specified
gaearon commentedon Dec 9, 2016
Agree. 👍
Want to make a PR?
BenoitAverty commentedon Dec 10, 2016
Yeah I'll open on now. Thanks !
gaearon commentedon Dec 11, 2016
Should be fixed in
react-scripts@0.8.4. Please verify.https://github.com/facebookincubator/create-react-app/releases/tag/v0.8.4