Skip to content

doctor: combo check for android gradle plugin < 7.1 iff react-native <= 0.68 #1566

Closed

Description

@mikehardy

Describe the Feature

Doctor should determine the installed version of react-native (if one is installed), and if react-native is <= 0.68, it should verify that android gradle plugin is < 7.1

Possible Implementations

Unknown, need to experiment

Related Issues

#1554 - discussion of how to handle incompatibilities discovered after a react-native release
react/react-native#33057 - PR where issue will be resolved

Activity

  1. mikehardy commented on Mar 2, 2022

    @mikehardy
    ContributorAuthor

    Needs a more fine-grained test if possible, even because of https://issuetracker.google.com/issues/159411906

    If new architecture is enabled, android gradle plugin 7.2 will be needed or ./gradlew clean [edited based on good catch from Nicola] fails, but plugin > 7.0 is not okay until react-native 0.69+ so there is a version range + feature set that simply has a known incompatibility, that can be communicated to users though

    Noticed in reactwg/react-native-releases#13 (comment)

  2. cortinico commented on Mar 3, 2022

    @cortinico
    Member

    clean build fails

    To clarify, calling gradle clean will fail. Not a clean build (i.e. building from a clean repo). But yeah, worth to address

  3. mikehardy commented on Mar 3, 2022

    @mikehardy
    ContributorAuthor

    sorry! exactly correct, imprecise wording on my part. I'm going to edit the comment to take this in to account, good catch

  4. github-actions commented on Nov 26, 2022

    @github-actions

    There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions