Skip to content

refactor: rc-menu with accessibility - #385

Merged
zombieJ merged 93 commits into
masterfrom
refactor
May 2, 2021
Merged

zombieJ merged 93 commits into
masterfrom
refactor

Conversation

@zombieJ

@zombieJ zombieJ commented Apr 30, 2021

Copy link
Copy Markdown
Member

Need more test for this.

@codecov

codecov Bot commented Apr 30, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #385 (8135a29) into master (127e17e) will increase coverage by 4.18%.
The diff coverage is 99.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   95.64%   99.83%   +4.18%     
==========================================
  Files          11       24      +13     
  Lines         919      608     -311     
  Branches      274      148     -126     
==========================================
- Hits          879      607     -272     
+ Misses         40        1      -39     
Impacted Files Coverage Δ
src/hooks/useUUID.ts 90.90% <90.90%> (ø)
src/Divider.tsx 100.00% <100.00%> (ø)
src/Icon.tsx 100.00% <100.00%> (ø)
src/Menu.tsx 100.00% <100.00%> (+1.87%) ⬆️
src/MenuItem.tsx 100.00% <100.00%> (ø)
src/MenuItemGroup.tsx 100.00% <100.00%> (ø)
src/SubMenu/InlineSubMenuList.tsx 100.00% <100.00%> (ø)
src/SubMenu/PopupTrigger.tsx 100.00% <100.00%> (ø)
src/SubMenu/SubMenuList.tsx 100.00% <100.00%> (ø)
src/SubMenu/index.tsx 100.00% <100.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127e17e...8135a29. Read the comment docs.

@zombieJ
zombieJ merged commit 6e0849a into master May 2, 2021
@zombieJ
zombieJ deleted the refactor branch May 2, 2021 03:35
@patrickomeara

Copy link
Copy Markdown

Thanks for your work on this @zombieJ.

Is there a way to prevent the aria-hidden element being added to the DOM?

The upgrade to antd 4.16 has caused many issues in our app. Our component tests now return duplicate elements and nested Modals that use portals within the Menu.Items now display twice.

Preventing the hidden component being attached to the DOM would prevent both of our issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants