Repository navigation
Disable fan supply during suspend on A733 - #620
Open
wangyongsen11 wants to merge 1 commit into
Open
wangyongsen11 wants to merge 1 commit into
wangyongsen11 wants to merge 1 commit into
Conversation
Keeping the fan regulator enabled when PWM is disabled causes the fan to continue running during suspend. Select pwm_disable_reg_disable when a fan regulator is available to disable both the PWM output and fan supply. Signed-off-by: Wang Yongsen <wangyongsen@radxa.com>
RadxaYuntian
left a comment
RadxaYuntian
left a comment
Member
There was a problem hiding this comment.
不是应该先看看设备树是不是regulator在休眠还开启么
Author
设备树配置要求休眠关闭regulator，但 PMIC regulator 驱动没有实现相应回调，导致硬件上的 DC1SW1 在休眠期间实际上仍然开启 |
Member
|
所以不是应该修regulator驱动么 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping the fan regulator enabled when PWM is disabled causes the fan to continue running during suspend. Select pwm_disable_reg_disable when a fan regulator is available to disable both the PWM output and fan supply.