Repository navigation
fix(security): require patched Node trust stores - #198
Draft
fgabelmannjr wants to merge 2 commits into
Draft
fgabelmannjr wants to merge 2 commits into
fgabelmannjr wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require supported Node releases containing the affected emSign CA trust-store
fixes across source use, MCP selection, and published packages:
Changes
retire end-of-life 20/21/23 and older 22/24 patches from supported use.
pins, ship the shared policy in both app bundles and the npm launcher/SDK,
and derive published engine metadata from the root package.
support guidance and the Unreleased security note, and extend existing
runtime/npm contract tests. The composite action now selects host Node
24.22.1 before npm installation.
Test evidence
and 24.11.1 contain the affected emSign ECC G3 root.
After: supported runtimes exclude that root, insecure runtime selections
are rejected, and the final four focused suites pass: 44 tests. The additional
action contract suite passes 16 tests.
archive. Its Node binary matches the independently verified official
24.22.1 binary; its bundled CLI runs successfully.
the helper is included in published files, and generated engines match root.
failed five assertions across four files under load: timeouts, file-descriptor
exhaustion, and a performance threshold. Those four files then passed alone:
180 passed, two skipped. The final hosted broad-suite matrix is green.
failed two timing assertions: Cypher returned
timeoutinstead of its pathexpansion diagnostic, and LSP initialization exceeded 60 ms. All 73 tests in
those two files pass locally on both this branch and original main with
Node 24.22.1. Their tests and production modules are unchanged. A fresh run of the failed job passed unchanged. All six platform/Node matrix
jobs and all other reported checks are now green; no deadlines or assertions
were weakened.
fixture (
listen EPERM); identical assertions passed with listener permission.git diff --check, shell syntax, changed-workflow actionlint, and Ripwirequality/impact checks pass. General Markdown lint reports the same 411
pre-existing issues on the original README/constitution baseline.
Node 22.23.4 and
Node 24.22.1 document
the certificate-store update.
Checklist
[Unreleased]updated.Merge Danger
Door: two-way.
Blast Radius: runtimes.
Consumers using end-of-life Node or earlier 22/24 patches must upgrade. Rollout
requires rebuilding all six platform archives, the npm main and platform
packages, checksums, and provenance through the release workflow. This local
verification built one platform archive and did not publish releases.
Action release hold: published CLI 1.5.0 executes its own unpatched Node
with no supported host-runtime override. Do not use the composite action with
that package for incident remediation. After a reviewed release rebuilds all
platform bundles, select that actual published version with
codegraph-version.The pinned host alone cannot replace the bundled runtime.