Skip to content

fix(security): require patched Node trust stores - #198

Draft
fgabelmannjr wants to merge 2 commits into
mainfrom
fix/emudhra-ca-trust
Draft

fgabelmannjr wants to merge 2 commits into
mainfrom
fix/emudhra-ca-trust

Conversation

@fgabelmannjr

@fgabelmannjr fgabelmannjr commented Oct 21, 2026 •

Copy link
Copy Markdown

Summary

Require supported Node releases containing the affected emSign CA trust-store
fixes across source use, MCP selection, and published packages:

CLI / MCP selector / npm launcher / SDK
  -> shared patched-Node policy
bundle builder
  -> Node 24.22.1 + shared policy
  -> platform bundles and npm packages

Changes

  • Runtime floor: require Node 22.23.4+ within 22.x or 24.22.1+ within 24.x;
    retire end-of-life 20/21/23 and older 22/24 patches from supported use.
  • Distribution: update the default bundled runtime, reject insecure override
    pins, ship the shared policy in both app bundles and the npm launcher/SDK,
    and derive published engine metadata from the root package.
  • CI and documentation: pin active CI runtime selectors, update current
    support guidance and the Unreleased security note, and extend existing
    runtime/npm contract tests. The composite action now selects host Node
    24.22.1 before npm installation.

Test evidence

  • Before: the MCP selector accepted Node 22.23.3; installed Node 22.23.1
    and 24.11.1 contain the affected emSign ECC G3 root.
    After: supported runtimes exclude that root, insecure runtime selections
    are rejected, and the final four focused suites pass: 44 tests. The additional
    action contract suite passes 16 tests.
  • Real bundle build passed the full app/web build and produced a darwin/arm64
    archive. Its Node binary matches the independently verified official
    24.22.1 binary; its bundled CLI runs successfully.
  • Real npm packaging passed: app/platform and main-package policy copies exist,
    the helper is included in published files, and generated engines match root.
  • Root TypeScript checking passed. Earlier broad tests passed 4,861 tests and
    failed five assertions across four files under load: timeouts, file-descriptor
    exhaustion, and a performance threshold. Those four files then passed alone:
    180 passed, two skipped. The final hosted broad-suite matrix is green.
  • Hosted CI run 39659313875 initially passed five matrix jobs; macOS Node 24.22.1
    failed two timing assertions: Cypher returned timeout instead of its path
    expansion diagnostic, and LSP initialization exceeded 60 ms. All 73 tests in
    those two files pass locally on both this branch and original main with
    Node 24.22.1. Their tests and production modules are unchanged. A fresh run of the failed job passed unchanged. All six platform/Node matrix
    jobs and all other reported checks are now green; no deadlines or assertions
    were weakened.
  • The initial focused sandbox run was denied permission to bind its local HTTPS
    fixture (listen EPERM); identical assertions passed with listener permission.
  • git diff --check, shell syntax, changed-workflow actionlint, and Ripwire
    quality/impact checks pass. General Markdown lint reports the same 411
    pre-existing issues on the original README/constitution baseline.

Node 22.23.4 and
Node 24.22.1 document
the certificate-store update.

Checklist

  • CHANGELOG.md [Unreleased] updated.
  • Installer source is unchanged; its scoped coverage requirement is not triggered.
  • No AI session URLs in this PR, its commit, or its branch.

Merge Danger

Door: two-way.

Blast Radius: runtimes.

Consumers using end-of-life Node or earlier 22/24 patches must upgrade. Rollout
requires rebuilding all six platform archives, the npm main and platform
packages, checksums, and provenance through the release workflow. This local
verification built one platform archive and did not publish releases.

Action release hold: published CLI 1.5.0 executes its own unpatched Node
with no supported host-runtime override. Do not use the composite action with
that package for incident remediation. After a reviewed release rebuilds all
platform bundles, select that actual published version with codegraph-version.
The pinned host alone cannot replace the bundled runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant