Repository navigation
SPEC-020: PR Blast-Radius Review Action - #154
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds SPEC-020’s reusable “PR Impact” composite GitHub Action to generate and deliver a deterministic CodeGraph blast-radius report on pull requests (with fork-safe degradation), along with dogfood workflow wiring, packaging/build integration for the compiled helper runtime, and a focused test suite plus spec artifacts.
Changes:
- Introduces
actions/pr-impact/composite action + compiled helper runtime to runcodegraph detect-changesand publish a deterministic report with sticky-comment + summary/artifact fallback. - Adds advisory self-dogfood workflow for CodeGraph PRs and integrates helper build output into
npm run build+ package publishing. - Adds comprehensive Vitest coverage for action contract, cache validation, delivery/result-matrix behavior, narrative degradation, and runtime freshness; updates roadmap/spec docs and changelog.
Reviewed changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/020-pr-blast-radius-review-action/verify-tasks-report.md | Task verification report artifact |
| specs/020-pr-blast-radius-review-action/uat-runbook.md | Manual UAT steps/runbook |
| specs/020-pr-blast-radius-review-action/tasks.md | Dependency-ordered implementation tasks |
| specs/020-pr-blast-radius-review-action/spec.md | Feature spec (US/FR/SC) |
| specs/020-pr-blast-radius-review-action/SPEC-MOC.md | Spec map-of-content marker |
| specs/020-pr-blast-radius-review-action/retrospective.md | Implementation retrospective notes |
| specs/020-pr-blast-radius-review-action/research.md | Design decisions & references |
| specs/020-pr-blast-radius-review-action/quickstart.md | Local verification quickstart |
| specs/020-pr-blast-radius-review-action/pr-review-packet.md | Review packet & evidence |
| specs/020-pr-blast-radius-review-action/pr-body.md | Generated PR body text |
| specs/020-pr-blast-radius-review-action/plan.md | Implementation plan & gates |
| specs/020-pr-blast-radius-review-action/data-model.md | Action/cache/delivery data model |
| specs/020-pr-blast-radius-review-action/contracts/result-matrix.md | Contract for conclusion mapping |
| specs/020-pr-blast-radius-review-action/contracts/report-contract.md | Deterministic report contract |
| specs/020-pr-blast-radius-review-action/contracts/action-contract.md | Action I/O contract documentation |
| specs/020-pr-blast-radius-review-action/code-review-report.md | Recorded review findings/remediation |
| specs/020-pr-blast-radius-review-action/checklists/security.md | Generated security checklist |
| specs/020-pr-blast-radius-review-action/checklists/requirements.md | Generated requirements checklist |
| specs/020-pr-blast-radius-review-action/checklists/performance.md | Generated performance checklist |
| specs/020-pr-blast-radius-review-action/checklists/error-handling.md | Generated error-handling checklist |
| specs/020-pr-blast-radius-review-action/checklists/api-contracts.md | Generated API-contracts checklist |
| actions/pr-impact/action.yml | Composite action definition + steps |
| actions/pr-impact/README.md | Action usage & behavior documentation |
| actions/pr-impact/run.ts | Helper source for orchestration/reporting |
| actions/pr-impact/dist/run.mjs | Generated compiled helper runtime |
| .github/workflows/pr-impact.yml | Advisory dogfood workflow for PRs |
| tests/fixtures/pr-impact.ts | Deterministic fixtures for tests |
| tests/pr-impact-action-contract.test.ts | Action contract + workflow pinning tests |
| tests/pr-impact-runtime-freshness.test.ts | Generated runtime freshness tests |
| tests/pr-impact-delivery.test.ts | Comment/summary/artifact delivery tests |
| tests/pr-impact-result-matrix.test.ts | Conclusion mapping/result-matrix tests |
| tests/pr-impact-cache.test.ts | Cache validation/rebuild behavior tests |
| tests/pr-impact-narrative.test.ts | Narrative suppression/degradation tests |
| package.json | Build + package surface updates (actions + helper build) |
| CHANGELOG.md | Unreleased feature note for PR impact action |
| .gitignore | Unignore generated action runtime for commit |
| docs/ai/specs/intelligence-platform-technical-roadmap.md | Roadmap status update for SPEC-020 |
| docs/ai/specs/intelligence-platform-roadmap-MOC.md | Adds SPEC-020 to roadmap MOC index |
| docs/ai/specs/.process/SPEC-020-workflow.md | SPEC-020 workflow artifact |
| docs/ai/specs/.process/SPEC-020-design-concept.md | SPEC-020 design concept/Q&A log |
| .specify/feature.json | SpecKit feature directory pointer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodeGraph PR ImpactRun metadata
Summary
Changed symbols
Impacted callers
Affected flows
Risks
Warnings
Limits
Fallback delivery note
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPEC-020: PR Blast-Radius Review Action
What changed
actions/pr-impact/.Why
Reviewers need one current deterministic blast-radius report on pull requests. The action keeps ordinary impact advisory, enforces only opt-in thresholds, validates restored graph caches before use, and keeps optional narrative prose-only.
Non-goals
pull_request_targetexecution of untrusted PR code.Review order
actions/pr-impact/action.ymlactions/pr-impact/README.mdactions/pr-impact/run.tsactions/pr-impact/dist/run.mjs__tests__/pr-impact-*.test.ts.github/workflows/pr-impact.ymlCHANGELOG.mdScope budget
Traceability
actions/pr-impact/run.ts,actions/pr-impact/action.yml__tests__/pr-impact-delivery.test.tsactions/pr-impact/run.ts__tests__/pr-impact-delivery.test.ts,__tests__/pr-impact-result-matrix.test.tsactions/pr-impact/run.ts__tests__/pr-impact-result-matrix.test.ts,__tests__/pr-impact-action-contract.test.tsactions/pr-impact/run.ts,actions/pr-impact/action.yml__tests__/pr-impact-cache.test.tsactions/pr-impact/run.ts__tests__/pr-impact-narrative.test.ts.github/workflows/pr-impact.yml__tests__/pr-impact-action-contract.test.tsactions/pr-impact/dist/run.mjs__tests__/pr-impact-runtime-freshness.test.tsVerification
npm run build: PASS.npm run typecheck: PASS.npm test: PARTIAL — 239 files passed; onedetect-changes-clitest timed out under full-suite load.npm test -- __tests__/detect-changes-cli.test.ts: PASS — 1 file, 4 tests.actions/*references are pinned to full commit SHAs.file:.installation.base-refuses the computed merge base/base SHA for detector execution in detached PR checkouts.pr-impact, CodeQL, dependency review, installer coverage guard, and OS/Node test matrix passed on run29464931728.Known gaps
Rollback
.github/workflows/pr-impact.ymlto disable dogfood.uses: ./actions/pr-impactworkflow step for consumers.