Repository navigation
Track the Tyk2 inputs used by the FEP setup tests - #136
Merged
Merged
Conversation
test_fep_input_files and test_softcore_methods read ligand parameters and a neutralized protein from untracked files under tutorials/Tyk2/setupFEP, so they failed in a clean checkout. The inputs now live in test/qligfep/resources/tyk2_ejm_31_ejm_45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
test_fep_input_files.pyandtest_softcore_methods.pyread their Tyk2 inputs from files undertutorials/Tyk2/setupFEP/that are not tracked (ejm_31/ejm_45.lib,.prm,.sdf,.pdb, and the neutralized protein). In a clean checkout both files fail withFileNotFoundError.The inputs are now tracked in
test/qligfep/resources/tyk2_ejm_31_ejm_45/:ejm_31andejm_45parameters, generated with the currentqparams(atomic charges sum to exactly 0)protein_neutralized.pdb, the protein the golden FEP setup files were generated fromBoth tests and the golden-data generator in
conftest.pyread from that directory. Water still comes from the trackedtutorials/Tyk2/setupFEP/water.pdb. The golden files are unchanged.Testing
In a clean checkout of this branch (only
qprepbuilt):test_fep_input_files.pyandtest_softcore_methods.py, 21 passed.