[armanist]

Refs #612. This pull request targets 3.1.x, so it does not close the issue; the merge of 3.1.x into master does.

What changed

• Table::addColumn(), Table::modifyColumn() and Column::__construct() accept a Type case or the type as text again. A text type is used as before, in upper case, so any SQL type name works, including those that Type has no case for (integer, bigint, mediumtext).
• Table::addIndex() and Table::setAction() stay enum-only.
• The CHANGELOG.md entry of Convert the first batch of Enums classes to PHP enums #612 is corrected to match.

Why

The enum conversion in #640 made these three methods take Type only. The quantum/project starter migrations write the column type as text (addColumn('id', 'integer'), 'char', 'varchar', 'text', 'timestamp', 31 calls in 3 files), and the migration pages of the documentation show the same, so php qt migrate on a new project would throw a TypeError. 'integer' is not a Type value either (Type::INT is 'int'), and the enum has only 17 types, while the column type used to be any SQL type name.

Breaking changes

None compared to 3.1.0: the behavior of these three methods is the same as before #640. The BREAKING note for the other converted classes is unchanged.

Testing

• The three tests that required a TypeError for a text type are replaced by accept-text tests. They fail before this change with the TypeError and pass after it:
  • BIGINT(20), INTEGER and MEDIUMTEXT in the generated CREATE TABLE
  • modifyColumn('name', 'varchar', 50) gives the same SQL as the enum
  • new Column(..., Type::VARCHAR) and new Column(..., 'varchar') have the same type

Notes for reviewers

• Merge this before the merge of 3.1.x into master (Merge 3.1.x into master #641), so master never gets the strict version.
• Nothing is released yet: the strict version exists only on 3.1.x and master.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!