Skip to content

Fix template regressions: missing Response return/import in controllers and middleware #498

Closed

Description

@armanist

Summary

Two regressions remain in module templates after the remove response param in templates work:

  1. validateRequest() response is not returned in DemoWeb password middleware template.
  2. CommentController in DemoWeb template uses : Response return types without importing Quantum\\Http\\Response.
  3. Toolkit EmailsController::delete() calls redirect(...) without returning it, while method return type is Response.

Affected files

  • src/Module/Templates/DemoWeb/src/Middlewares/Password.php.tpl
  • src/Module/Templates/DemoWeb/src/Controllers/CommentController.php.tpl
  • src/Module/Templates/Toolkit/src/Controllers/EmailsController.php.tpl

Expected

All template methods typed as Response should always return a Response, and Response type should be properly imported where used.

Proposed fix

  • Return $errorResponse when validateRequest() fails.
  • Add missing use Quantum\\Http\\Response; import.
  • Return redirect(...) in EmailsController::delete().

Activity

  1. added this to the 3.0.0 milestone on May 4, 2026
  2. added a commit that references this issue on May 4, 2026
  3. added 2 commits that reference this issue on May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions