Repository navigation
Refactor app execution flow to remove stop()-driven control flow #469
Description
Summary
Refactor application execution flow so normal web and console control paths do not rely on stop() and StopExecutionException.
The end state should be:
- explicit return-driven flow in web
- explicit return-driven / exit-code-driven flow in console
- fluent
ResponseAPI for HTTP pipelines - consistent handling of controllers, middleware, and hooks
Why this is an umbrella
This work crosses multiple layers:
- HTTP response API
- router dispatch
- middleware pipeline
WebAppAdapterConsoleAppAdapter- shared app helpers and exception flow
This should not land as one large ticket because:
- web and console have different semantics
- shared control-flow changes need ordered rollout
- behavior changes need isolated validation
Child tickets
- Fluent
ResponseAPI and strict dispatcher return contract - Web middleware/controller/hook return-flow refactor
WebAppAdapterand web helper cleanupConsoleAppAdaptertermination refactor- Shared cleanup for
stop()andStopExecutionException
End-state requirements
WebAppAdapter::start(): ?intremains unchanged and always returns0ConsoleAppAdapter::start(): ?intremains unchanged and preserves meaningful exit codes- actions return
Response - middleware returns
Response - hooks follow the same explicit-return principle
- normal web flow does not depend on
stop() - normal console flow does not depend on
stop()
Validation
Each child ticket should land with focused validation, then the umbrella closes only after full validation:
composer testcomposer phpstancomposer cs:check
Activity
armanist commentedon Apr 29, 2026
Closing umbrella as completed.\n\nCompleted child tickets:\n- #470 Fluent Response API + dispatcher return contract\n- #471 Web middleware/controller/hook explicit Response flow\n- #472 WebAppAdapter + web helper stop() removal\n- #473 ConsoleAppAdapter explicit exit-code return flow\n- #474 Shared stop()/StopExecutionException cleanup\n\nEnd-state achieved:\n- Normal web and console flows are return-driven (not stop()-driven).\n- stop()/StopExecutionException removed from ordinary execution paths.\n- Contracts preserved (WebAppAdapter::start(): ?int, ConsoleAppAdapter::start(): ?int).\n\nValidation run across the series:\n- vendor/bin/phpunit\n- composer phpstan\n- composer cs:check\n\nClosing #469.