Repository navigation
docs: fill documentation gaps found after the 3.1 changes - #149
Merged
Merged
Conversation
…the core:env lookup
… response decoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills documentation gaps found after the 3.1 changes (quantum-php/framework#585, #575, #599, #534, #566, #567).
What changed
packages/logger/contracts.md: the PSR-3 methods takestring|Stringable $message, and a subclass that overrides them must declare the same type.packages/ratelimit/adapters.md: the file adapter creates the missing parent folders of itspath.packages/console/built-in-commands.md:core:envlooks for.envand.env.examplein the project base directory, not in the folder the command runs from.packages/httpclient/usage.md,overview.md,architecture.md, checked against real requests:getErrors()also holds an entry for an HTTP 4xx or 5xx answer, not only for a cURL failure. The old text said the opposite.setData()is sent: JSON for a JSON content type, form-encoded for other arrays, multipart for aCURLFile, a string as it isaddGet()appends its data as a query string, andaddPost()is shownSimpleXMLElementsetHeaders()replaces the tracked setgetMethod(),getData(),getAdapter(),isMultiRequest()andHttpClient::METHODSChanged paths
v3.0/packages/logger/contracts.mdv3.0/packages/ratelimit/adapters.mdv3.0/packages/console/built-in-commands.mdv3.0/packages/httpclient/usage.mdv3.0/packages/httpclient/overview.mdv3.0/packages/httpclient/architecture.mdSUMMARY.md: no change.