Repository navigation
Conversation
…ger and validator utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculator.divide: throwDivision by zerowhenb === 0string-utils: implementtruncate(word-boundary,...counted in maxLength);wordCounthandles repeated whitespacedate-utils.formatRelative: useMath.roundfor days (36h → "2 days ago")task-manager: implementremove,update,sortBy(priority/createdAt/status)validator:isEmailaccepts 2+ letter TLDs;isUrlaccepts portsbun test: 60 pass, 0 fail (was 16 failing).tsc --noEmitclean. No test files or dependencies changed.Assumptions
sortBy("status")orders pending → in_progress → completed (no test covers it; it was in the existing type signature).truncatewithmaxLength < 3still returns"..."(untested edge case, left as is).updateusesObject.assign, so it doesn't guard against callers overwritingid. Review rated this low severity.