Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"types": ["bun-types"](already installed) sobun:testandprocessresolve undertsc.User.userName→usernameto match the API routes and tests.badRequestimport.publicMethodscontained"post"but Hono reports uppercase methods; now"POST".paginate()(1-indexed pages,totalPages = ceil(total/size), empty data past the end). Page/size are normalised to integers ≥ 1 so bad input can't produce Infinity/NaN or bypass the size limit.// BUG:comments.Result:
bun test22/22 pass;tsc --noEmitclean.Assumptions / notes for reviewers
POST /users,POST /posts). This matches the middleware doc comment andauth.test.ts("POST is intentionally public"), which can't be modified, so I treated it as intended. Before this behaviour is relied on in production, the owner should confirm that unauthenticated writes are acceptable.paginate()goes beyond what the tests require and has no dedicated tests yet.pagination.tsdocblock, and a comment inauth.test.ts:21, which is a test file and was left untouched.