Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth.ts: public-methods list had lowercase"post", so POST /users returned 401 → now"POST".users.ts: added missingbadRequestimport (caused 500 instead of 400).shared/types.ts: renamedUser.userName→usernameto match api package and tests.shared/utils/pagination.ts: implementedpaginate(1-indexed page; returns data, total, totalPages, pageSize).tsconfig.json: added"types": ["bun-types"](already installed) to resolvebun:test/processtype errors.Result: 22/22 tests pass,
tsc --noEmitexits 0. No test files modified, no dependencies added.Assumptions / follow-ups
paginatedoesn't validate size<=0/fractional inputs — not required by tests; worth clamping before wiring to query params.test-tokenfallback in auth, non-constant-time token compare, unpinnedbun-types: latest. Stale "BUG" comments left to keep diff minimal.