Skip to content

fix: resolve failing tests and type errors - #287

Open
stooit wants to merge 1 commit into
mainfrom
quantcode/e2e-tier2-982-1794154270
Open

stooit wants to merge 1 commit into
mainfrom
quantcode/e2e-tier2-982-1794154270

Conversation

@stooit

@stooit stooit commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Fixes: auth middleware POST case bug; missing badRequest import in users route; shared User.userName -> username; implemented paginate (clamps page/size >= 1); tsconfig types bun-types (already installed). Removed stale BUG/TODO source comments. 22/22 tests pass, tsc --noEmit clean.

Assumptions/notes:

  • POST being public follows the middleware docstring and auth.test.ts; it lets unauthenticated users create records, so please confirm that's the intended policy.
  • Pre-existing: auth falls back to 'test-token' when API_TOKEN is unset; recommend failing closed in prod.
  • paginate does not guard NaN or cap size; unused by routes today.
  • No new deps; no test files modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant