Skip to content

fix: repair failing tests and type errors across monorepo - #293

Open
stooit wants to merge 1 commit into
mainfrom
quantcode/e2e-tier3-919-1794582360
Open

stooit wants to merge 1 commit into
mainfrom
quantcode/e2e-tier3-919-1794582360

Conversation

@stooit

@stooit stooit commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Makes bun test && tsc --noEmit pass (13/13 tests, 0 type errors). No test files modified, no dependencies added.

  • bunfig.toml: replaced invalid environment = "happy-dom" with preload of existing packages/ui/test/setup.ts (fixes document is not defined).
  • tsconfig.json: added types: ["bun-types"] (already installed) for bun:test types.
  • apps/web/src/lib/api.ts: import renamed useDebounce instead of removed useThrottle; useSearchDebounce export unchanged.
  • Button.tsx: always forwards aria-label; icon-only without label warns and falls back to "Button".
  • DataTable.tsx: functional setSortDir(prev => ...) fixes stale state.
  • date.ts: formatDate builds D/MM/YYYY via formatToParts.

Assumptions / follow-ups

  • The Button test requires a non-null aria-label even when none is passed; the "Button" fallback is a stopgap. Follow-up: require aria-label at type level for iconOnly and gate the warning to dev.
  • Review agent found no critical/high issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant