Repository navigation
Conversation
- bunfig: preload happy-dom setup (environment key is unsupported by bun) - tsconfig: include bun-types for bun:test - web: import renamed useDebounce instead of useThrottle - ui/Button: pass aria-label through to the button element - ui/DataTable: use functional setState for sort toggle (stale closure) - utils/date: en-AU format with unpadded day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
bun test && tsc --noEmitpass (13/13 tests, 0 type errors). No test files modified, no dependencies added.environment = "happy-dom"is not a Bun option; replaced withpreloadof the existing happy-dom setup file.types: ["bun-types"](already installed) sobun:testresolves.useThrottlewas renamed touseDebouncein@e2e/utils; import updated,useSearchDebouncere-export unchanged.aria-labelwas destructured but never applied; now passed through.sortDirclosure in sort toggle; now functionalsetSortDir(prev => ...).formatToPartsto give1/03/2024as the test expects (en-AU default zero-pads the day).Assumptions / follow-ups
aria-labelattribute on icon-only buttons even with none passed. Fallback is the string child, else empty string — gives no real accessible name, so callers should still supply one. A dev-time warning is a sensible follow-up (out of scope).formatDatepadding now differs fromformatDateTime(dateStyle: short), as the test dictates.BUG:comments remain and could be cleaned up.