Repository navigation
Conversation
- utils rename: use useDebounce (formerly useThrottle) in apps/web api - ui Button: render aria-label with icon-only fallback and dev warning - utils formatDate: unpadded day, padded month (en-AU) e.g. 1/03/2024 - bunfig.toml: preload happy-dom setup (invalid 'environment' key removed) - tsconfig: add bun-types for bun:test typings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root
bun testnow passes 13/13 (it was 9 failing).tsc --noEmitis clean.useThrottle, which had been renamed touseDebounceinpackages/utils. It now importsuseDebounceand still re-exports it asuseSearchDebounce.aria-labelthrough to the rendered button. If an icon-only button has no label, it falls back to string children, then to"Button"as a placeholder. Outside production it also logs aconsole.warn, which the test name and the component docstring both asked for.1/03/2024), which is what the test expects. This changes visible output for days 1–9, which used to render as01/03/2024.environment = "happy-dom", which isn't a valid Bun option, so no DOM was being set up. It now preloadspackages/ui/test/setup.ts.bun-typestotypesso thebun:testimports type-check.bun-typeswas already a devDependency.Assumptions
handleSortis recreated on every render, soDataTable.tsxwas left unchanged.tscisn't on PATH in this environment, so I ran the type check withbunx tsc --noEmit."Button"fallback label exists only because the test requires some non-empty label. Callers should still pass a meaningfularia-label.