Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
bun test(13/13) andtsc --noEmitpass from the repo root. No test files were changed and no dependencies were added.environment = "happy-dom"is not a Bun option, so it was ignored. Replaced it with a preload of the existingpackages/ui/test/setup.ts, which uses the already-installed@happy-dom/global-registrator. This fixes thedocument is not definederrors.useDebounceinstead of the old nameuseThrottle.aria-labelprop is now applied to the<button>. Icon-only buttons with no label fall back to"Button".setSortDir(prev => …)), which fixes the stale closure.formatDatenow outputsD/MM/YYYY, e.g.1/03/2024. It builds the string fromformatToParts, because en-AU zero-pads the day in this environment."types": ["bun-types"]sobun:testresolves during type-checking.Assumptions / follow-ups
aria-label, so a fallback is needed."Button"is not a descriptive name for screen readers, though. Callers should always pass a real label, and a dev-mode warning would be a good follow-up.tscis not on PATH, so the type check was run withbunx tsc --noEmit.