Repository navigation
7.3.0: rules deploy messages, quant serve --run background dev servers, local KV secrets, serve.json defaults - #297
Merged
Merged
Conversation
A 422 can say that the requested rule order cannot be kept (a retry does not help), and a 409 can say that the change may already be live. Print that message as one short line. The old texts stay as the fallback when the response has no message.
…to the background When the --run command exits 0 and its process group is still alive, print one notice that it moved to the background instead of "stopped (exit code 0)". quant serve already stops the whole group on exit. When only the --proxy URL still answers, say that quant serve cannot stop that dev server. A non-zero exit keeps the old message. Windows has no process group, which the README now says.
The value is stored as a function stores it with secret: true. A function on quant serve reads it, and a list shows it masked.
quant serve and quant kv --local read optional org, project and meta from quant/serve.json, so a project without quant.json needs no flags on every call. A flag still wins, and quant/serve.json wins over quant.json. The values are validated.
…nt org or project The quant/serve.json value is used. quant serve prints the warning in the start-up output, and quant kv --local prints it to stderr.
A yes/no question after the JSON value, default no.
…code A string error without a message is printed above the old advice (retry for 409, check URL and scopes for 422). A message still replaces the advice. deployError moves its text into helpers (complexity 10 or less).
…e stops stopRun aborts the poll, so it never keeps Node alive after a stop.
set prints the entry with the value [ENCRYPTED], the mask of a list. The menu asks for a secret value with hidden input. --secret on get, list or delete prints one notice that it is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 7.3.0.
Changed
quant rules: when the rules API refuses a deploy with 409 or 422 and gives a message, the CLI now prints that message. A 422 can say that the requested rule order cannot be kept (a retry does not help). A 409 can say that the change may already be live (reload the rules and check them; a retry is safe). If the body has only anerrorcode, the CLI prints it above the previous advice. Without either, the previous texts stay. Exit codes do not change.quant serve --run: when the command exits 0 and its process group is still alive (the dev server moved to the background), quant serve prints one notice, keeps serving and stops the whole process group when it stops. If only the--proxyURL still answers, quant serve says that it cannot stop that dev server. A non-zero exit gives the previous message. Windows has no process group, so quant serve cannot stop a dev server that moved to the background there.Added
quant kv set --local --secretstores the value encrypted, assecret: truedoes in a function. A function onquant servereads the value.setandlistshow it as[ENCRYPTED];get --localshows the value. The interactivekv setmenu asks the same question (default no) and then asks for a secret value with hidden input.--secretonget,listordeleteprints a notice that it is ignored.quant/serve.jsoncan setorg,projectandmetadefaults forquant serveandquant kv --local. The order is: flag,quant/serve.json,quant.json, default. Whenquant/serve.jsonandquant.jsonset a different org or project and no flag chooses, the CLI prints one warning that names the value it uses. The values are validated.Testing