Skip to content

QCLINUX: arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for… - #1297

Open
ganesh-maurya-gv wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
ganesh-maurya-gv:feature/aggregator-rx-flag
Open

ganesh-maurya-gv wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
ganesh-maurya-gv:feature/aggregator-rx-flag

Conversation

@ganesh-maurya-gv

@ganesh-maurya-gv ganesh-maurya-gv commented Oct 15, 2026 •

Copy link
Copy Markdown

… CSIPHY mux mode.

Add the aggregator-rx property so the CSIPHY driver knows the link carries aggregated streams. In CSIPHY mux mode it can then configure the receiver for multiple virtual channels instead of assuming a single-sensor link.

CRs-Fixed: 4712504

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

2 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1297 — validate-patch

PR: #1297

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; required for all non-vendor commits
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link; commit has no vendor prefix to indicate vendor-only status
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1297 - arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ❌ No upstream source to compare against
Body preserves rationale ❌ No upstream commit message to verify against
Fixes tag present/correct N/A No Fixes tag present; not a bugfix
Authorship preserved ❌ No vendor prefix; unclear if vendor-only or missing upstream attribution
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi ❌ Cannot validate without upstream source

Issues

  1. Missing lore.kernel.org link: No Link: tag found in commit message. Per kernel submission guidelines, all patches should reference their upstream posting or clearly indicate vendor-only status with a QCLINUX: prefix.

  2. Missing commit prefix: The commit subject lacks a required prefix:

    • If this change was posted upstream → add FROMLIST: prefix + lore link
    • If merged upstream → add UPSTREAM: or BACKPORT: prefix + lore link
    • If vendor-only (not suitable for upstream) → add QCLINUX: prefix
  3. Gerrit Change-Id present: Change-Id: I16e749fdb2ece9d99fbae1af84d03dd656b9ab36 should be removed before merging to the public kernel tree. Change-Id tags are internal Gerrit workflow artifacts and are not accepted in upstream Linux kernel commits.

  4. Not present in qcom-next or topics: Per integration_presence_report.md, this commit is missing from both qcom-next and all topic branches. New commits should typically land in a topic branch first before being integrated.

Verdict

Do not merge. This commit requires one of the following corrections:

  • If vendor-only: Add QCLINUX: prefix to subject, remove Change-Id tag, and submit to appropriate topic branch first.
  • If upstream-bound: Post to relevant mailing list (linux-arm-msm@vger.kernel.org), add FROMLIST: prefix + lore link, remove Change-Id tag.
  • If already upstream: Add UPSTREAM: or BACKPORT: prefix + lore link to the merged commit, remove Change-Id tag.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; required for all non-vendor commits
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link; commit has no vendor prefix to indicate vendor-only status
  4. PR present in qcom-next/topics: Fail — commit is missing from both qcom-next (0/1) and all topic branches (0/1); per integration_presence_report.md: "1/1 commit(s) are missing from both qcom-next and topics"

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1297 — checker-log-analyzer

PR: #1297
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38726503292

Checker Result Summary
Checker Result Summary
checkpatch ❌ 2 errors, 1 warning
dt-binding-check ⏭️ No binding changes
dtb-check ❌ Pre-existing errors in qcs6490-camera.dtsi
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Missing subject prefix
tag-check ❌ Missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1297 - arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38726503292

Checker Result Summary
checkpatch ❌ 2 errors, 1 warning
dt-binding-check ⏭️ No binding changes
dtb-check ❌ Pre-existing errors in qcs6490-camera.dtsi
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Missing subject prefix
tag-check ❌ Missing required prefix

❌ checkpatch

Root cause: Commit contains Gerrit Change-Id, missing Signed-off-by, and long commit body line.

Failure details:

Commit e668025218ab ("arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode.")

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
Add the aggregator-rx property so the CSIPHY driver knows the link carries aggregated streams. In CSIPHY mux mode it can then configure the receiver for multiple virtual channels instead of assuming a single-sensor link.

ERROR: Remove Gerrit Change-Id's before submitting upstream
#9: 
Change-Id: I16e749fdb2ece9d99fbae1af84d03dd656b9ab36

ERROR: Missing Signed-off-by: line(s)

e668025218abc320519a8ec3be9552d34ec7b502 total: 2 errors, 1 warnings, 0 checks, 35 lines checked

Fix:

git rebase -i a4d631a5f8fd   # mark commit as 'edit'

# Edit commit message to:
# 1. Remove the Change-Id line
# 2. Wrap the long description line at 75 chars
# 3. Add Signed-off-by trailer

git commit --amend

# New commit message should be:
# arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode.
#
# Add the aggregator-rx property so the CSIPHY driver knows the link
# carries aggregated streams. In CSIPHY mux mode it can then configure
# the receiver for multiple virtual channels instead of assuming a
# single-sensor link.
#
# Signed-off-by: Ganesh Maurya G V <ggv@qti.qualcomm.com>

git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a4d631a5f8fd..e668025218ab

❌ dtb-check

Root cause: Pre-existing errors in qcs6490-camera.dtsi — not introduced by this PR.

Failure details:
The dtb-check log shows numerous reg_format, avoid_default_addr_size, and interrupts_property warnings for nodes in qcs6490-camera.dtsi:

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1411.3-36: Warning (reg_format): /fragment@0/__overlay__/qcom,csiphy1:reg: property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1361.28-1406.4: Warning (avoid_default_addr_size): /fragment@0/__overlay__/qcom,csiphy0: Relying on default #address-cells value
../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1361.28-1406.4: Warning (interrupts_property): /fragment@0/__overlay__/qcom,csiphy0: Missing interrupt-parent

Analysis: This PR only adds the aggregator-rx; boolean property to five CSIPHY nodes. It does not modify reg, #address-cells, #size-cells, or interrupt-parent properties. All reported errors are pre-existing issues in the camera DTSI overlay file that were present before this PR.

These are not blockers for this PR — the dtb-check failures are tree-wide issues that should be fixed separately.

Fix: None required for this PR. The pre-existing errors should be addressed in a separate cleanup patch series.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix.

Failure details:

Checking commit: arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode.
Commit summary does not start with a required prefix

Fix:

The commit subject must start with one of the allowed prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:.

Based on the nature of this change (vendor-specific DTS property for CSIPHY mux mode), the appropriate prefix is likely QCLINUX: (vendor-only) or PENDING: (work-in-progress).

Note: If this prefix is QCLINUX: or PENDING:, the check-patch-compliance checker will continue to fail because it only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known limitation of the checker for vendor-only commits.

git rebase -i a4d631a5f8fd   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode.

Add the aggregator-rx property so the CSIPHY driver knows the link
carries aggregated streams. In CSIPHY mux mode it can then configure
the receiver for multiple virtual channels instead of assuming a
single-sensor link.

Signed-off-by: Ganesh Maurya G V <ggv@qti.qualcomm.com>"
git rebase --continue

Alternative: If this change has been posted to a mailing list (lore.kernel.org), use FROMLIST: prefix and add a Link: trailer pointing to the lore URL.

Reproduce locally:

# This checker requires the kernel-checkers repo
bash kernel-checkers/check-patch-compliance.sh --kernel-src . --base a4d631a5f8fd --head e668025218ab

❌ tag-check

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

The commit subject is:

arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode.

This does not start with any of the required prefix tags: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:.

Note: This check applies to all branches except qcom-next and qcom-next-staging. If the target branch is one of those two, this check should be skipped. However, based on the check-patch-compliance failure, it appears the target branch requires prefixes.

Fix:

Same as the check-patch-compliance fix above — add the appropriate prefix to the commit subject:

git rebase -i a4d631a5f8fd   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for CSIPHY mux mode.

Add the aggregator-rx property so the CSIPHY driver knows the link
carries aggregated streams. In CSIPHY mux mode it can then configure
the receiver for multiple virtual channels instead of assuming a
single-sensor link.

Signed-off-by: Ganesh Maurya G V <ggv@qti.qualcomm.com>"
git rebase --continue

Choose the correct prefix based on the patch origin:

  • Posted to lore but not yet merged → FROMLIST:
  • In a maintainer tree → FROMGIT:
  • Merged into Linus's tree → UPSTREAM:
  • Backported with modifications → BACKPORT:
  • Vendor-only, no upstream → QCLINUX:
  • Work-in-progress, not yet posted → PENDING:
  • Temporary fix, not for upstream → WORKAROUND:

Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Remove Gerrit Change-Id, add Signed-off-by, wrap long commit body line
  2. check-patch-compliance — Add required subject prefix (QCLINUX: or FROMLIST: + Link:)
  3. tag-check — Add required subject prefix (same fix as Adding Email Checker  #2)

Not blockers:

  • dtb-check failures are pre-existing tree issues in qcs6490-camera.dtsi, not introduced by this PR

Summary: The code change itself (adding aggregator-rx; property) is fine. The commit message needs formatting fixes: remove Change-Id, add Signed-off-by, wrap long lines, and add a subject prefix tag.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

3 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4712504 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4712504

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@ganesh-maurya-gv ganesh-maurya-gv changed the title arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for… QCLINUX: arm64: dts: qcom: qcs6490-rb3gen2: Add aggregator rx flag support for… Oct 16, 2026
…pport for CSIPHY mux mode.

Add the aggregator-rx property so the CSIPHY driver knows the link
carries aggregated streams. In CSIPHY mux mode it can then configure
the receiver for multiple virtual channels instead of assuming a
single-sensor link.

Change-Id: I5670bea9b8ec37ed064e94d2ac2331165dfdc1f3
Signed-off-by: Ganesh Maurya G V <ggv@qti.qualcomm.com>
@ganesh-maurya-gv
ganesh-maurya-gv force-pushed the feature/aggregator-rx-flag branch from e668025 to 7b06f4b Compare October 16, 2026 06:52
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4712504 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4712504

Please ensure the CR has a change task associated with at least one of the entities for this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants