Skip to content

FROMLIST: arm64: dts: qcom: shikra: Remove cdsp compute-cb@9 - #1272

Open
Anandu Krishnan E (quic-anane) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
quic-anane:shikra-remove-cdsp-compute-cb9-6.18y
Open

Anandu Krishnan E (quic-anane) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
quic-anane:shikra-remove-cdsp-compute-cb9-6.18y

Conversation

@quic-anane

Copy link
Copy Markdown

Remove the context bank compute-cb@9 as it is a secure context bank used for secure use cases. Secure use case support is not currently implemented upstream, and allowing other use cases to be offloaded onto this context bank results in an SMMU fault.

Fixes: 8b6f81f ("arm64: dts: qcom: shikra: Add CDSP, LPAICP, MPSS remoteproc PAS nodes")

Cc: stable@kernel.org

Link: https://lore.kernel.org/r/20260929-shikra-dts-cdsp-compute-cb-fix-v1-1-90e4abb873d6@oss.qualcomm.com
CRs-Fixed: 4635461

Remove the context bank compute-cb@9 as it is a secure context bank
used for secure use cases. Secure use case support is not currently
implemented upstream, and allowing other use cases to be offloaded
onto this context bank results in an SMMU fault.

Fixes: 8b6f81f ("arm64: dts: qcom: shikra: Add CDSP, LPAICP, MPSS remoteproc PAS nodes")

Cc: stable@kernel.org

Link: https://lore.kernel.org/r/20260929-shikra-dts-cdsp-compute-cb-fix-v1-1-90e4abb873d6@oss.qualcomm.com
CRs-Fixed: 4635461
Signed-off-by: Anandu Krishnan E <anandu.e@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4635461 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4635461

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #1272 — validate-patch

PR: #1272

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/r/20260929-shikra-dts-cdsp-compute-cb-fix-v1-1-90e4abb873d6@oss.qualcomm.com
  2. Lore link matches PR commits: Yes — diff content identical; context offset (947 lines) due to vendor tree having more content than upstream base
  3. Upstream patch status: ⏳ In review — Reviewed-by: Konrad Dybcio (2026-09-29); not yet merged into mainline or maintainer tree
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1272 - FROMLIST: arm64: dts: qcom: shikra: Remove cdsp compute-cb@9
Upstream commit: https://lore.kernel.org/r/20260929-shikra-dts-cdsp-compute-cb-fix-v1-1-90e4abb873d6@oss.qualcomm.com
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ PR adds FROMLIST: prefix (expected); upstream subject is arm64: dts: qcom: shikra: Remove cdsp compute-cb@9
Body preserves rationale ✅ Identical - explains secure context bank issue and SMMU fault
Fixes tag present/correct ✅ Fixes: 8b6f81f7801a present in both
Authorship preserved ✅ From: matches lore author (Anandu Krishnan E) - correct for FROMLIST:
Backport note (if applicable) N/A Not a backport - posted to mailing list but not yet merged
Extra metadata ⚠️ PR adds CRs-Fixed: 4635461 (vendor-specific, acceptable) and Link: tag (correct)

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ Context differs: lore hunk at line 1948, PR hunk at line 2895 (947-line offset); code change identical

Upstream Patch Status

Commit Community Verdict
arm64: dts: qcom: shikra: Remove cdsp compute-cb@9 ⏳ Decision Pending — Reviewed-by: Konrad Dybcio on 2026-09-29; no merge confirmation yet

Issues

  • Context offset: The PR applies the patch at line 2895, while the lore patch targets line 1948. This is a 947-line difference, indicating the PR's base tree has significantly more content in shikra.dtsi than the upstream tree the lore patch was based on. The code change itself (removing compute-cb@9 node) is identical.
  • Vendor metadata: PR adds CRs-Fixed: 4635461 which is not in the lore patch. This is acceptable vendor-specific metadata.

Verdict

The patch content is faithful to the lore source. The subject correctly uses FROMLIST: prefix since the patch has been posted to the mailing list but not yet merged upstream. The commit message body, Fixes tag, and authorship are all correct. The diff shows a large context offset (947 lines) but the actual code change is identical. The patch has received Reviewed-by: from Konrad Dybcio but has not been merged into mainline yet.

Recommendation: Merge with awareness that this is ahead of upstream acceptance. The large context offset suggests the vendor tree has additional content not yet upstream.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/r/20260929-shikra-dts-cdsp-compute-cb-fix-v1-1-90e4abb873d6@oss.qualcomm.com
  2. Lore link matches PR commits: Yes — diff content identical; context offset (947 lines) due to vendor tree having more content than upstream base
  3. Upstream patch status: ⏳ In review — Reviewed-by: Konrad Dybcio (2026-09-29); not yet merged into mainline or maintainer tree
  4. PR present in qcom-next/topics: No — integration_presence_report.md shows 1/1 commit missing from both qcom-next and topics (FAIL)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: shikra: Remove cdsp compute-cb@9 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1272 — checker-log-analyzer

PR: #1272
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38230016301

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 warning: Unknown commit ID in Fixes tag
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Test passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ✅ Passed
tag-check ✅ Valid FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1272 - FROMLIST: arm64: dts: qcom: shikra: Remove cdsp compute-cb@9
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38230016301

Checker Result Summary
checkpatch ❌ 1 warning: Unknown commit ID in Fixes tag
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Test passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ✅ Passed
tag-check ✅ Valid FROMLIST: prefix present

❌ checkpatch

Root cause: The Fixes: tag references commit 8b6f81f7801a which is not present in the checked-out tree at the time of validation.

Failure details:

WARNING: Unknown commit id '8b6f81f7801a', maybe rebased or not pulled?
#11: 
Fixes: 8b6f81f7801a ("arm64: dts: qcom: shikra: Add CDSP, LPAICP, MPSS remoteproc PAS nodes")

c28211ce6dab471f7343c1dcde520551af8f95d9 total: 0 errors, 1 warnings, 0 checks, 12 lines checked

Commit c28211ce6dab ("FROMLIST: arm64: dts: qcom: shikra: Remove cdsp compute-cb@9") has style problems, please review.

Analysis:

This is a WARNING (not an ERROR), meaning it's advisory rather than blocking. The warning occurs because checkpatch cannot find commit 8b6f81f7801a in the current git history. This can happen for several reasons:

  1. The commit exists in a different branch or remote that wasn't fetched during CI
  2. The commit was rebased/rewritten with a different SHA
  3. The commit is in the upstream tree but not in the base branch being checked

Fix:

Verify the Fixes tag references the correct commit:

# Search for the commit in the full tree
git log --all --oneline --grep="Add CDSP, LPAICP, MPSS remoteproc PAS nodes" | grep shikra

# If found with a different SHA, update the Fixes tag:
git rebase -i <base_sha>   # mark commit as 'edit'
# Update the commit message with the correct SHA
git commit --amend
git rebase --continue

If the commit truly exists in the target branch history, this warning can be safely ignored as a CI environment limitation (the base tree may not have had all refs fetched).

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git ab439ff21547145a1b6b13bc471f4383ac7e9b66..c28211ce6dab471f7343c1dcde520551af8f95d9

Verdict

1 non-blocking warning to review before merge.

The checkpatch warning about the unknown commit ID in the Fixes: tag should be verified:

  • If commit 8b6f81f7801a exists in the target branch, the warning is a false positive due to CI fetch limitations and can be ignored.
  • If the commit SHA is incorrect or the commit was rebased, update the Fixes: tag with the correct SHA.

All other checkers passed or were correctly skipped. The patch is otherwise compliant with kernel coding standards and has proper upstream attribution (FROMLIST: prefix + Link: tag).

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk-multimedia lemans-evk-multimedia monaco-evk-multimedia purwa-iot-evk-multimedia qcs615-ride-multimedia qcs6490-rb3gen2-multimedia qcs8300-ride-multimedia qcs9100-ride-r3-multimedia shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ✅ Pass ◻️ ✅ Pass ⚠️ skip ✅ Pass ◻️ ⚠️ skip ◻️
BT_FW_KMD_Service ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
KVM_Driver ❌ Fail ✅ Pass ◻️ ❌ Fail ❌ Fail ✅ Pass ◻️ ❌ Fail ◻️
KVM_EL2_DTB ❌ Fail ✅ Pass ◻️ ❌ Fail ❌ Fail ✅ Pass ◻️ ❌ Fail ◻️
KVM_Infra ❌ Fail ✅ Pass ◻️ ❌ Fail ❌ Fail ✅ Pass ◻️ ❌ Fail ◻️
OpenCV ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ◻️
WiFi_Firmware_Driver ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
WiFi_OnOff ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
gpdsp_remoteproc ⚠️ skip ✅ Pass ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ◻️
hotplug ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants