Skip to content

arm64: dts: qcom: shikra: disable unused CTI - #1260

Open
Bibek Kumar Patro (bibekpatro) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
bibekpatro:shikra-optee-coresight
Open

Bibek Kumar Patro (bibekpatro) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
bibekpatro:shikra-optee-coresight

Conversation

@bibekpatro

Copy link
Copy Markdown

Summary

  • Add optee node under firmware {} to enable OP-TEE as the TEE backend on Shikra; required for remoteproc subsystems (e.g. lpaicp) that use OP-TEE for firmware authentication and controlled startup
  • Disable cti@982b000 (cti_riscv): the RISCV core is not present on Shikra so this CTI node should not be probed

Test plan

  • Boot Shikra board, verify optee device appears in /sys/bus/platform/devices/
  • Confirm no coresight probe errors for cti@982b000
  • Trigger lpaicp load manually and confirm OP-TEE PAS authentication succeeds

🤖 Generated with Claude Code

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1260 — validate-patch

PR: #1260

Verdict Issues Detailed Report
❌ 2 Full report

Final Summary

  1. Lore link present: Not provided in agent output
  2. Lore link matches PR commits: Not provided in agent output
  3. Upstream patch status: Not provided in agent output
  4. PR present in qcom-next/topics: Partial - 2/4 commit(s) only have partial integration evidence
Verdict: ❌ — click to expand

🔍 Patch Validation Report

PR: #1260
Commits: 4 commits (2 vendor-specific DTS, 1 FROMLIST remoteproc, 1 vendor-specific remoteproc)
Verdict: ❌ FAIL


Commit 1/4: arm64: dts: qcom: shikra: Add OP-TEE firmware node

Upstream: N/A (vendor-specific)
Verdict: ⚠️ WARNING

Commit Message

Check Status Note
Subject matches upstream N/A No upstream source
Body preserves rationale ✅ Clear description of purpose
Fixes tag present/correct N/A Not a fix
Authorship preserved ✅ Bibek Kumar Patro
Backport note N/A Not a backport
Co-Authored-By usage ⚠️ Co-Authored-By: Claude <noreply@anthropic.com> - unusual for kernel commits

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Adds OP-TEE firmware node

Issues

  • Co-Authored-By tag: The Co-Authored-By: Claude <noreply@anthropic.com> tag is unusual for kernel commits. If Claude is an AI assistant, this attribution is inappropriate. If this is a genuine co-author, use a real email address.
  • Change-Id: Gerrit-style Change-Id tags are not used in upstream kernel commits and should be removed before submission.

Final Summary

  1. Lore link present: No — vendor-specific Shikra DTS change; no lore link expected
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific platform enablement
  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified"

Commit 2/4: arm64: dts: qcom: shikra: Disable cti_riscv node

Upstream: N/A (vendor-specific)
Verdict: ⚠️ WARNING

Commit Message

Check Status Note
Subject matches upstream N/A No upstream source
Body preserves rationale ✅ Clear explanation of why node is disabled
Fixes tag present/correct N/A Not a fix
Authorship preserved ✅ Bibek Kumar Patro
Backport note N/A Not a backport
Co-Authored-By usage ⚠️ Co-Authored-By: Claude <noreply@anthropic.com> - unusual for kernel commits

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Adds status = "disabled" to cti_riscv node

Issues

  • Co-Authored-By tag: Same issue as commit 1/4 - Co-Authored-By: Claude <noreply@anthropic.com> is inappropriate.
  • Change-Id: Gerrit-style Change-Id tag should be removed.

Final Summary

  1. Lore link present: No — vendor-specific Shikra DTS change; no lore link expected
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific platform fix
  4. PR present in qcom-next/topics: Present — integration_presence_report.md shows "present - all checked added lines are present"

Commit 3/4: FROMLIST: remoteproc: qcom: pas: pass no resource table when the firmware has none

Upstream: MISSING - No lore.kernel.org link found
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ❌ Cannot verify - no lore link provided
Body preserves rationale ✅ Detailed problem description with crash trace
Fixes tag present/correct ✅ Fixes: a4584bff63c8 present
Authorship preserved ⚠️ Jorge Ramirez-Ortiz is original author, Bibek Kumar Patro is submitter
Backport note N/A Not a backport
Co-Authored-By usage ✅ Not used

Diff

File Status Notes
drivers/remoteproc/qcom_q6v5_pas.c ❌ Cannot verify against upstream - no lore link

Issues

CRITICAL: Missing lore.kernel.org link

This commit uses the FROMLIST: prefix, which requires a Link: https://lore.kernel.org/r/<message-id> tag in the commit message. Per the validate-patch skill:

FROMLIST: — Posted to mailing list, not yet merged — Yes — lore.kernel.org link required

The commit message must include a line like:

Link: https://lore.kernel.org/r/<message-id>/

Without this link, it is impossible to:

  1. Verify that the patch content matches what was posted to the mailing list
  2. Check the upstream review status (ACKed/NACKed/Pending)
  3. Ensure the correct revision is being used (v1, v2, v3, etc.)
  4. Validate that authorship and sign-offs are preserved correctly

Authorship note for FROMLIST commits:

  • The original author (Jorge Ramirez-Ortiz) must appear in Signed-off-by: — ✅ Present
  • The submitter (Bibek Kumar Patro) appears in From: and adds their own Signed-off-by: — ✅ Correct
  • This authorship pattern is correct for FROMLIST: commits

Change-Id tag:

  • Gerrit-style Change-Id should be removed before upstream submission

Final Summary

  1. Lore link present: ❌ No — FROMLIST: prefix requires a lore.kernel.org link, but none found
  2. Lore link matches PR commits: ❌ Cannot verify — no lore link to compare against
  3. Upstream patch status: ❌ Cannot determine — no lore link to check review status
  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified"

Commit 4/4: remoteproc: qcom: shikra: Disable auto-boot for all PIL subsystems

Upstream: N/A (vendor-specific)
Verdict: ✅ PASS (with minor warnings)

Commit Message

Check Status Note
Subject matches upstream N/A No upstream source
Body preserves rationale ✅ Clear explanation of why auto_boot is disabled
Fixes tag present/correct N/A Not a fix
Authorship preserved ✅ Bibek Kumar Patro
Backport note N/A Not a backport
Co-Authored-By usage ✅ Not used

Diff

File Status Notes
drivers/remoteproc/qcom_q6v5_pas.c ✅ Changes auto_boot from true to false for cdsp and lpaicp

Issues

  • Change-Id: Gerrit-style Change-Id tag should be removed if submitting upstream.
  • Vendor-specific: This change is specific to Shikra platform behavior with OP-TEE, unlikely to be upstreamed as-is.

Final Summary

  1. Lore link present: No — vendor-specific Shikra platform configuration; no lore link expected
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific platform configuration
  4. PR present in qcom-next/topics: Present — integration_presence_report.md shows "present - all checked added lines are present"

Overall PR Verdict: ❌ FAIL

Critical Issues

  1. Commit 3/4 FAIL: The FROMLIST: prefix requires a Link: https://lore.kernel.org/r/<message-id> tag, but none is present. This commit cannot be validated without the lore link.

Warnings

  1. Commits 1/4 and 2/4: Inappropriate Co-Authored-By: Claude <noreply@anthropic.com> tags. If Claude is an AI assistant, this attribution should be removed. Kernel commits should only credit human contributors with valid email addresses.

  2. All commits: Gerrit-style Change-Id tags should be removed before upstream submission (though they may be acceptable in vendor trees).

Recommendation

DO NOT MERGE until the following corrections are made:

  1. Commit 3/4 (CRITICAL): Add the lore.kernel.org link to the commit message:

    Link: https://lore.kernel.org/r/<message-id>/
    

    Then re-run validation to verify the patch content matches the lore posting and check upstream review status.

  2. Commits 1/4 and 2/4: Remove the Co-Authored-By: Claude <noreply@anthropic.com> lines.

  3. All commits (optional): Remove Change-Id tags if these commits will be submitted upstream.

After corrections, re-submit the PR for validation.


Integration Status Summary

Per integration_presence_report.md:

  • Overall status: PARTIAL
  • Present commits: 2/4 (commits 2/4 and 4/4)
  • Partial commits: 2/4 (commits 1/4 and 3/4)
  • Missing commits: 0/4

The partial status for commits 1/4 and 3/4 indicates that while some evidence was found in qcom-next, the full changes could not be verified. This aligns with the validation findings that these commits have issues requiring correction.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/4 [PATCH 1/4] arm64: dts: qcom: shikra: Add OP-TEE firmware node partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
2/4 [PATCH 2/4] arm64: dts: qcom: shikra: Disable cti_riscv node present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
3/4 [PATCH 3/4] FROMLIST: remoteproc: qcom: pas: pass no resource table partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
4/4 [PATCH 4/4] remoteproc: qcom: shikra: Disable auto-boot for all PIL present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: PARTIAL
present_commits: 2/4
partial_commits: 2/4
missing_commits: 0/4
topics_checked_for_commits: 2/4
final_summary: PR present in qcom-next/topics: Partial - 2/4 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1260 — checker-log-analyzer

PR: #1260
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37843179933

Checker Result Summary
Checker Result Summary
checkpatch ❌ 4 commits with errors: Change-Id, missing Signed-off-by, Co-Authored-By format
dt-binding-check ⏭️ No DT binding changes
dtb-check ✅ All DTB validations passed
sparse-check ✅ No sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ 3 commits missing required prefix, 1 commit missing Link
tag-check ❌ 3 commits missing required subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1260 - Shikra remoteproc and firmware updates
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/37843179933
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 4 commits with errors: Change-Id, missing Signed-off-by, Co-Authored-By format
dt-binding-check ⏭️ No DT binding changes
dtb-check ✅ All DTB validations passed
sparse-check ✅ No sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ 3 commits missing required prefix, 1 commit missing Link
tag-check ❌ 3 commits missing required subject prefix (mandatory for qcom-6.18.y)

❌ checkpatch

Root cause: All 4 commits contain Gerrit Change-Id tags that must be removed before upstream submission. Commits 1 and 2 also have missing Signed-off-by and incorrect Co-Authored-By format.

Failure details:

Commit 1: 55ae639 ("arm64: dts: qcom: shikra: Add OP-TEE firmware node")

ERROR: Remove Gerrit Change-Id's before submitting upstream
#12: Change-Id: I139ff6b6e658ff41d0b792bf2029300017019d84

WARNING: Non-standard signature: Co-Authored-By:
#13: Co-Authored-By: Claude <noreply@anthropic.com>

WARNING: 'Co-authored-by:' is the preferred signature form

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 2 warnings

Commit 2: b8847ef ("arm64: dts: qcom: shikra: Disable cti_riscv node")

ERROR: Remove Gerrit Change-Id's before submitting upstream
#10: Change-Id: Ia7904334bff9de0e55ad4d08f6af5446edb8d9ef

WARNING: Non-standard signature: Co-Authored-By:
#11: Co-Authored-By: Claude <noreply@anthropic.com>

WARNING: 'Co-authored-by:' is the preferred signature form

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 2 warnings

Commit 3: c4dad8b ("FROMLIST: remoteproc: qcom: pas: pass no resource table when the firmware has none")

ERROR: Remove Gerrit Change-Id's before submitting upstream
#28: Change-Id: I48b0cc8ff9a78e24425c9e554944e2631880e4ad

WARNING: Unknown commit id 'a4584bff63c8', maybe rebased or not pulled?
#29: Fixes: a4584bff63c8 ("remoteproc: pas: Extend parse_fw callback to fetch resources via SMC call")

total: 1 errors, 1 warnings

Commit 4: 5b5c29b ("remoteproc: qcom: shikra: Disable auto-boot for all PIL subsystems")

ERROR: Remove Gerrit Change-Id's before submitting upstream
#12: Change-Id: I443b0bf92c1a465ad0be924de836a51cafa23744

total: 1 errors

Fix:

For all 4 commits, remove the Change-Id: line:

git rebase -i f19f3cdab691f3d6d8bcccf03e46669ba4e714ea
# Mark each commit as 'edit'
# For each commit:
git commit --amend  # Remove Change-Id line from commit message
git rebase --continue

For commits 1 and 2, additionally:

  1. Add Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com> to the commit message
  2. Change Co-Authored-By: to Co-developed-by: (lowercase 'd') and add a matching Signed-off-by: for the co-author, or remove it entirely if Claude is not a genuine co-author

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git f19f3cdab691f3d6d8bcccf03e46669ba4e714ea..5b5c29bff168e437fe53d38c99790215d9c10ea6

❌ check-patch-compliance

Root cause: Three commits lack required subject prefix tags (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), and one FROMLIST: commit is missing the mandatory Link: trailer.

Failure details:

Checking commit: arm64: dts: qcom: shikra: Add OP-TEE firmware node
Commit summary does not start with a required prefix

Checking commit: arm64: dts: qcom: shikra: Disable cti_riscv node
Commit summary does not start with a required prefix

Checking commit: FROMLIST: remoteproc: qcom: pas: pass no resource table when the firmware has none
No 'Link' found in commit message

Checking commit: remoteproc: qcom: shikra: Disable auto-boot for all PIL subsystems
Commit summary does not start with a required prefix

Fix:

Commits 1, 2, 4 — Add appropriate prefix:

  • If these patches are posted to lore.kernel.org → use FROMLIST: and add Link: trailer
  • If vendor-only with no upstream equivalent → use QCLINUX: (note: checker will still fail, known limitation)
  • If work-in-progress → use PENDING: (note: checker will still fail, known limitation)

Commit 3 — Add Link: trailer pointing to the lore.kernel.org message:

git rebase -i <base>
# Mark commit c4dad8b34f33 as 'edit'
git commit --amend
# Add to commit body:
# Link: https://lore.kernel.org/r/<message-id>
git rebase --continue

Reproduce locally:

# For each commit, verify with b4:
b4 am --single-message -C -l -3 <lore-link> -o /tmp/out

❌ tag-check — Mandatory Subject Prefix

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must start with a valid prefix tag. Three commits are missing prefixes.

Failure details:

Commit 1: 55ae639

Subject: arm64: dts: qcom: shikra: Add OP-TEE firmware node
❌ Missing required prefix

Commit 2: b8847ef

Subject: arm64: dts: qcom: shikra: Disable cti_riscv node
❌ Missing required prefix

Commit 4: 5b5c29b

Subject: remoteproc: qcom: shikra: Disable auto-boot for all PIL subsystems
❌ Missing required prefix

Commit 3: c4dad8b

Subject: FROMLIST: remoteproc: qcom: pas: pass no resource table when the firmware has none
✅ Has valid prefix (FROMLIST:)

Fix:

Choose the correct prefix based on patch origin:

Prefix When to use
FROMLIST: Posted to lore.kernel.org, not yet merged
FROMGIT: In a maintainer git tree
UPSTREAM: Merged into Linus's mainline tree
BACKPORT: Upstream patch backported with modifications
QCLINUX: Vendor-only, no upstream equivalent
PENDING: Work-in-progress, not posted upstream
WORKAROUND: Temporary fix not suitable for upstream
git rebase -i f19f3cdab691f3d6d8bcccf03e46669ba4e714ea
# Mark commits 1, 2, 4 as 'edit'
# For each:
git commit --amend -m "FROMLIST: <original subject>"  # or QCLINUX:/PENDING: as appropriate
git rebase --continue

Reproduce locally:

git log f19f3cdab691..5b5c29bff168 --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix: $sha $subject"
  fi
done

Verdict

5 blockers must be fixed before merge:

  1. All 4 commits: Remove Gerrit Change-Id: lines
  2. Commits 1 & 2: Add Signed-off-by: and fix Co-Authored-By: format
  3. Commits 1, 2, 4: Add required subject prefix (FROMLIST:/QCLINUX:/PENDING:)
  4. Commit 3: Add Link: trailer pointing to lore.kernel.org
  5. All commits: Ensure compliance with kernel coding style

Note: If commits 1, 2, 4 are vendor-only (QCLINUX:) or work-in-progress (PENDING:), the check-patch-compliance checker will continue to fail — this is a known checker limitation for non-upstream-linkable prefixes. However, the tag-check requirement is still satisfied by adding the prefix.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1260 — validate-patch

PR: #1260

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; cannot validate against upstream source
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — without a lore link or vendor prefix, cannot determine if this is upstream, fromlist, or vendor-only
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1260 — arm64: dts: qcom: shikra: Disable cti_riscv node
Upstream commit: N/A — no lore.kernel.org link found
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ❌ No lore link to compare; missing vendor prefix (UPSTREAM:/FROMLIST:/QCLINUX:)
Body preserves rationale ⚠️ Rationale present but no upstream source to verify against
Fixes tag present/correct N/A No Fixes tag; not applicable for this change
Authorship preserved ❌ Co-Authored-By: Claude noreply@anthropic.com is invalid; missing Signed-off-by
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ Change is simple (adds status = "disabled"), but cannot verify against upstream source

Issues

  1. No lore.kernel.org link — Cannot validate patch content against upstream source
  2. Missing vendor prefix — Subject should start with UPSTREAM:/FROMLIST:/BACKPORT:/QCLINUX: to indicate patch origin
  3. Invalid Co-Authored-By — "Claude noreply@anthropic.com" is not a legitimate co-author; appears to be test/placeholder data
  4. Missing Signed-off-by — No Signed-off-by trailer from author Bibek Kumar Patro
  5. Change-Id present — Gerrit-style Change-Id should be removed before submission to kernel trees

Verdict

Do not merge without correction. This commit lacks the required metadata for kernel patch submission: no vendor prefix to indicate origin, no lore link if upstream/fromlist, invalid Co-Authored-By trailer, and missing Signed-off-by. If this is a vendor-only change, add QCLINUX: prefix and remove the invalid Co-Authored-By line. If this is from upstream, add the appropriate prefix (UPSTREAM:/FROMLIST:/BACKPORT:) and Link: tag, then remove Change-Id.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; cannot validate against upstream source
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — without a lore link or vendor prefix, cannot determine if this is upstream, fromlist, or vendor-only
  4. PR present in qcom-next/topics: Yes — commit is present in qcom-next (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] arm64: dts: qcom: shikra: Disable cti_riscv node present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 0/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #1260 — checker-log-analyzer

PR: #1260
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38246245626

Checker Result Summary
Checker Result Summary
checkpatch ❌ 2 errors, 2 warnings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Missing required prefix
tag-check ❌ Subject prefix required for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1260 — arm64: dts: qcom: shikra: Disable cti_riscv node
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38246245626

Checker Result Summary
checkpatch ❌ 2 errors, 2 warnings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Missing required prefix
tag-check ❌ Subject prefix required for qcom-6.18.y

❌ checkpatch

Root cause: Commit contains Gerrit Change-Id, non-standard Co-Authored-By tag, and missing Signed-off-by trailer.

Failure details:

ERROR: Remove Gerrit Change-Id's before submitting upstream
#10: 
Change-Id: Ia7904334bff9de0e55ad4d08f6af5446edb8d9ef

WARNING: Non-standard signature: Co-Authored-By:
#11: 
Co-Authored-By: Claude <noreply@anthropic.com>

WARNING: 'Co-authored-by:' is the preferred signature form
#11: 
Co-Authored-By: Claude <noreply@anthropic.com>

ERROR: Missing Signed-off-by: line(s)

2004aff889eb7e039a6943580181eaf8df1486fc total: 2 errors, 2 warnings, 0 checks, 7 lines checked

Fix:

git rebase -i ab439ff21547   # mark commit as 'edit'
# Remove the Change-Id line from commit message
# Change Co-Authored-By to Co-developed-by (lowercase 'd')
# Add Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
git commit --amend
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git ab439ff21547..2004aff889eb

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: arm64: dts: qcom: shikra: Disable cti_riscv node
Commit summary does not start with a required prefix

Fix:

This is a vendor-specific DTS change (disabling a non-functional RISCV CTI node on Shikra). Choose the appropriate prefix:

  • If this change has been posted to the upstream mailing list → use FROMLIST:
  • If this is a vendor-only change with no upstream equivalent → use QCLINUX:
git rebase -i ab439ff21547   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node

The RISCV CTI node at 0x982b000 is not functional on Shikra as the
RISCV core is not present. Mark it disabled to prevent coresight
from attempting to probe it.

Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>"
git rebase --continue

Note: If you use QCLINUX:, the check-patch-compliance checker will still fail because it only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). This is a known checker limitation for vendor-only commits. However, the tag-check requirement (see below) will be satisfied.


❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must start with a valid prefix tag.

Failure details:

Commit 2004aff889eb ("arm64: dts: qcom: shikra: Disable cti_riscv node"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

Same as the check-patch-compliance fix above — add a prefix to the subject line:

git rebase -i ab439ff21547   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node

The RISCV CTI node at 0x982b000 is not functional on Shikra as the
RISCV core is not present. Mark it disabled to prevent coresight
from attempting to probe it.

Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>"
git rebase --continue

Choose the correct prefix based on the patch origin:

  • Posted to lore but not yet merged → FROMLIST:
  • In a maintainer tree → FROMGIT:
  • Merged into Linus's tree → UPSTREAM:
  • Backported with modifications → BACKPORT:
  • Vendor-only, no upstream → QCLINUX:

Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Remove Change-Id, fix Co-Authored-By → Co-developed-by, add Signed-off-by
  2. check-patch-compliance — Add subject prefix (QCLINUX: recommended for vendor-only DTS change)
  3. tag-check — Add subject prefix (same fix as Adding Email Checker  #2)

All three issues can be resolved in a single git commit --amend:

git rebase -i ab439ff21547   # mark commit as 'edit'
git commit --amend
# Edit commit message to:
#   - Subject: QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node
#   - Remove Change-Id line
#   - Change Co-Authored-By to Co-developed-by (if keeping co-author credit)
#   - Add Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
git rebase --continue

After fixing, re-trigger CI to verify all checkers pass.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1260 — validate-patch

PR: #1260

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; appears to be vendor-specific change requiring QCLINUX: prefix
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific change, not posted upstream (expected for platform-specific hardware disablement)
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1260 - arm64: dts: qcom: shikra: Disable cti_riscv node
Upstream commit: N/A (no lore link found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream lore link to compare
Body preserves rationale ✅ Clear explanation of why node is disabled
Fixes tag present/correct N/A Not a bug fix; no Fixes tag needed
Authorship preserved ⚠️ Co-Authored-By contains placeholder email
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Single-line addition is correct; disables non-functional CTI node

Issues

Critical:

  1. Missing vendor prefix — Commit subject lacks required prefix. This appears to be a vendor-specific change (disabling hardware not present on Shikra). Should be prefixed with QCLINUX: to indicate no upstream equivalent is expected.

  2. Change-Id present — Gerrit artifact Change-Id: Ia7904334bff9de0e55ad4d08f6af5446edb8d9ef must be removed. Kernel commits should not contain Change-Id tags.

  3. Co-Authored-By misuse — Co-Authored-By: Claude <noreply@anthropic.com> appears to be a placeholder/test value. Remove this line or replace with a real co-author if applicable.

Note: The technical content of the patch (adding status = "disabled";) is correct and the rationale is sound.

Verdict

Do not merge — Commit message hygiene issues must be fixed:

  1. Add QCLINUX: prefix to subject line
  2. Remove Change-Id: tag
  3. Remove or fix Co-Authored-By: line

Suggested subject: QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; appears to be vendor-specific change requiring QCLINUX: prefix
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific change, not posted upstream (expected for platform-specific hardware disablement)
  4. PR present in qcom-next/topics: Yes — commit is already present in qcom-next (all added lines found)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: cb7a416d2476d022a449e7d52475c28a6feb390d
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] arm64: dts: qcom: shikra: Disable cti_riscv node present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 0/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #1260 — checker-log-analyzer

PR: #1260
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38355992470

Checker Result Summary
Checker Result Summary
checkpatch ❌ 2 errors, 2 warnings: Change-Id, Co-Authored-By format, missing Signed-off-by
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Missing required subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1260 — arm64: dts: qcom: shikra: Disable cti_riscv node
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38355992470

Checker Result Summary
checkpatch ❌ 2 errors, 2 warnings: Change-Id, Co-Authored-By format, missing Signed-off-by
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Missing required subject prefix (mandatory for qcom-6.18.y)

❌ checkpatch

Root cause: Commit contains Gerrit Change-Id, incorrect Co-Authored-By format, and missing Signed-off-by trailer.

Failure details:

ERROR: Remove Gerrit Change-Id's before submitting upstream
#10: 
Change-Id: Ia7904334bff9de0e55ad4d08f6af5446edb8d9ef

WARNING: Non-standard signature: Co-Authored-By:
#11: 
Co-Authored-By: Claude <noreply@anthropic.com>

WARNING: 'Co-authored-by:' is the preferred signature form
#11: 
Co-Authored-By: Claude <noreply@anthropic.com>

ERROR: Missing Signed-off-by: line(s)

a5860c436c73a9ba075c25155f2a714f99a96715 total: 2 errors, 2 warnings, 0 checks, 7 lines checked

Fix:

git rebase -i 143c1172c89b   # mark commit as 'edit'
# Remove the Change-Id line
# Change Co-Authored-By to Co-developed-by (lowercase 'd')
# Add Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
git commit --amend
git rebase --continue

The commit message should look like:

arm64: dts: qcom: shikra: Disable cti_riscv node

The RISCV CTI node at 0x982b000 is not functional on Shikra as the
RISCV core is not present. Mark it disabled to prevent coresight
from attempting to probe it.

Co-developed-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 143c1172c89b..a5860c436c73

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: arm64: dts: qcom: shikra: Disable cti_riscv node
Commit summary does not start with a required prefix

Fix:

This is a devicetree-only change with no upstream link. Choose the appropriate prefix based on the patch origin:

  • If this patch has been posted to the mailing list → use FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL
  • If this is a vendor-only change with no upstream equivalent → use QCLINUX: (note: this will still fail check-patch-compliance, which is a known limitation for vendor-only commits)
  • If this is work-in-progress not yet posted → use PENDING: (note: this will also fail check-patch-compliance)

Most likely fix (assuming vendor-only):

git rebase -i 143c1172c89b   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node

The RISCV CTI node at 0x982b000 is not functional on Shikra as the
RISCV core is not present. Mark it disabled to prevent coresight
from attempting to probe it.

Co-developed-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>"
git rebase --continue

Note: QCLINUX: is not in the check-patch-compliance allowed list, so this checker will continue to fail. This is a known limitation for vendor-only commits.


❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires every commit subject to start with a valid prefix tag.

Failure details:

Commit a5860c436c73 ("arm64: dts: qcom: shikra: Disable cti_riscv node"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: — Patch posted to mailing list (lore.kernel.org)
  • FROMGIT: — Patch taken from a maintainer git tree
  • UPSTREAM: — Patch merged into Linus's mainline tree
  • BACKPORT: — Upstream patch backported with modifications
  • QCLINUX: — Vendor-only change with no upstream equivalent
  • PENDING: — Work-in-progress, not yet posted upstream
  • WORKAROUND: — Temporary fix not suitable for upstream

Fix:

Same as check-patch-compliance above — add the appropriate prefix to the subject line. For a vendor-only devicetree change, use QCLINUX::

git rebase -i 143c1172c89b   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node

[rest of commit message]"
git rebase --continue

Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Remove Change-Id, fix Co-Authored-By → Co-developed-by, add Signed-off-by
  2. check-patch-compliance — Add subject prefix (QCLINUX: for vendor-only, or FROMLIST: + Link: if posted upstream)
  3. tag-check — Add subject prefix (same fix as Adding Email Checker  #2)

All three issues can be resolved in a single git commit --amend by:

  • Removing the Change-Id: line
  • Changing Co-Authored-By: to Co-developed-by: (lowercase 'd')
  • Adding Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
  • Prefixing the subject with QCLINUX: (or the appropriate prefix based on patch origin)

Note: If QCLINUX: is used, check-patch-compliance will continue to fail due to a known checker limitation — this is acceptable for vendor-only commits.

The RISCV CTI node at 0x982b000 is not functional on Shikra as the
RISCV core is not present. Mark it disabled to prevent coresight
from attempting to probe it.

Change-Id: I73c2c0e88c51372c7a8a4a7117be599be606d4e6
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1260 — validate-patch

PR: #1260

Verdict Issues Detailed Report
❌ 2 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix present to indicate upstream status
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix; appears to be vendor-only change that should use QCLINUX: prefix
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1260 - arm64: dts: qcom: shikra: Disable cti_riscv node
Upstream commit: N/A (no lore.kernel.org link found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream link to compare against
Body preserves rationale N/A No upstream link to compare against
Fixes tag present/correct ❌ No Fixes tag; should reference commit that introduced cti_riscv node
Authorship preserved N/A No upstream to verify against
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ❌ Unrelated change: adds "Bibek" to model string
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ❌ Unrelated change: adds "Bibek" to model string
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ❌ Unrelated change: adds "Bibek" to model string
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Correctly adds status = "disabled" to cti_riscv node

Issues

Critical Issues:

  1. No vendor prefix in subject — The commit lacks a required prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:). All commits in this tree must have a prefix indicating their upstream status.

  2. No lore.kernel.org link — The commit message contains no Link: tag pointing to a lore.kernel.org posting. For vendor-only changes, use QCLINUX: prefix; for patches posted upstream, use FROMLIST: with the lore link.

  3. Unrelated changes mixed in — The patch modifies the model property in three board DTS files (shikra-cqm-evk.dts, shikra-cqs-evk.dts, shikra-iqs-evk.dts), adding "Bibek" to the model string. These changes are completely unrelated to disabling the cti_riscv node and appear to be accidental test/debug modifications that should not be committed.

  4. Invalid Co-Authored-By trailer — The commit contains Co-Authored-By: Claude <noreply@anthropic.com>, which is not a valid kernel trailer. Use Co-developed-by: for genuine co-authors (with their real identity and a matching Signed-off-by:), or remove if not applicable.

  5. Gerrit Change-Id present — The commit contains a Gerrit Change-Id: tag, which should be removed before submission to this tree (unless this tree uses Gerrit, which is not indicated).

  6. Missing Fixes tag — The commit should include a Fixes: tag referencing the commit that introduced the cti_riscv node to shikra.dtsi, to help with backporting and tracking.

Commit Message Structure Issues:

  • The commit message body is acceptable but could be improved with a Fixes: tag.
  • The subject line is clear and follows kernel conventions (subsystem prefix, brief description).

Verdict

Do not merge. This patch contains multiple critical issues:

  1. Remove the unrelated "Bibek" model string changes from all three board DTS files.
  2. Add the appropriate vendor prefix to the subject line:
    • If this is vendor-only: QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node
    • If posted upstream: FROMLIST: arm64: dts: qcom: shikra: Disable cti_riscv node with Link: tag
  3. Remove the invalid Co-Authored-By: Claude trailer.
  4. Remove the Change-Id: tag (unless required by this tree's workflow).
  5. Add a Fixes: tag referencing the commit that introduced the cti_riscv node.

The core change (adding status = "disabled" to cti_riscv in shikra.dtsi) is correct and addresses a real issue, but the commit must be cleaned up before merging.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix present to indicate upstream status
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix; appears to be vendor-only change that should use QCLINUX: prefix
  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows partial evidence (subject or partial tree match) but full change not verified; unrelated model string changes likely causing mismatch

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] arm64: dts: qcom: shikra: Disable cti_riscv node partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1260 — checker-log-analyzer

PR: #1260
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38699234340

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 error, 2 warnings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required prefix
tag-check ❌ Missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1260 - arm64: dts: qcom: shikra: Disable cti_riscv node
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38699234340

Checker Result Summary
checkpatch ❌ 1 error, 2 warnings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required prefix
tag-check ❌ Missing required prefix

❌ checkpatch

Root cause: Commit contains Gerrit Change-Id trailer (blocker) and non-standard signature format.

Failure details:

ERROR: Remove Gerrit Change-Id's before submitting upstream
#10: 
Change-Id: I73c2c0e88c51372c7a8a4a7117be599be606d4e6

WARNING: Non-standard signature: Co-Authored-By:
#11: 
Co-Authored-By: Claude <noreply@anthropic.com>

WARNING: 'Co-authored-by:' is the preferred signature form
#11: 
Co-Authored-By: Claude <noreply@anthropic.com>

8b688de8c6860f6188b4869c4862de2686a097b7 total: 1 errors, 2 warnings, 0 checks, 31 lines checked

Fix:

  1. Remove the Change-Id: line entirely (Gerrit-specific, not for upstream/kernel trees)
  2. Change Co-Authored-By: to Co-authored-by: (lowercase 'a' and 'b')
git rebase -i a4d631a5f8fd0b29ebea44758fddb3836272cd9f
# mark commit as 'edit'
git commit --amend
# Remove the Change-Id line and fix Co-Authored-By → Co-authored-by
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a4d631a5f8fd0b29ebea44758fddb3836272cd9f..8b688de8c6860f6188b4869c4862de2686a097b7

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: arm64: dts: qcom: shikra: Disable cti_riscv node
Commit summary does not start with a required prefix

The commit subject is:

arm64: dts: qcom: shikra: Disable cti_riscv node

This checker enforces that commits must have one of the following prefixes:

  • FROMLIST: — patch posted to lore.kernel.org
  • FROMGIT: — patch from a maintainer git tree
  • UPSTREAM: — patch merged into Linus's mainline
  • BACKPORT: — upstream patch backported with modifications

Fix:

Since this appears to be a vendor-specific change (disabling a node on Shikra hardware), you have two options:

  1. If this patch has been or will be posted upstream, add the appropriate prefix:

    git commit --amend -m "FROMLIST: arm64: dts: qcom: shikra: Disable cti_riscv node"
  2. If this is vendor-only, use QCLINUX: prefix (note: this will still fail check-patch-compliance as it's not in the allowed list, but documents the intent):

    git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node"

Note: The check-patch-compliance checker only accepts upstream-linkable prefixes. If this is truly vendor-only, the checker will continue to fail — this is a known limitation.


❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must start with a valid prefix tag.

Failure details:

Commit 8b688de8c6860f6188b4869c4862de2686a097b7 ("arm64: dts: qcom: shikra: Disable cti_riscv node"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

Choose the appropriate prefix based on the patch origin:

Situation Prefix
Posted to lore, not yet merged FROMLIST:
In a maintainer git tree FROMGIT:
Merged into Linus's tree UPSTREAM:
Backported with modifications BACKPORT:
Vendor-only, no upstream QCLINUX:
Work-in-progress, not posted PENDING:
Temporary fix, not for upstream WORKAROUND:
git rebase -i a4d631a5f8fd0b29ebea44758fddb3836272cd9f
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Disable cti_riscv node"
# (or use FROMLIST: if posted upstream)
git rebase --continue

⚠️ Additional Issue: Unrelated Changes

Root cause: The patch includes unrelated changes to board model strings that are not mentioned in the commit message.

Details:

The commit message states:

"Disable cti_riscv node... Mark it disabled to prevent coresight from attempting to probe it."

However, the patch also changes:

-	model = "Qualcomm Technologies, Inc. Shikra CQM EVK";
+	model = "Qualcomm Technologies, Inc. Bibek Shikra CQM EVK";

This appears in all three board files (shikra-cqm-evk.dts, shikra-cqs-evk.dts, shikra-iqs-evk.dts).

Fix:

These model string changes should either be:

  1. Removed if they were added accidentally
  2. Split into a separate commit with its own commit message explaining why "Bibek" is being added to the model strings

The current patch mixes two unrelated changes, which violates the "one logical change per commit" principle.


Verdict

3 blockers must be fixed before merge:

  1. checkpatch ERROR — Remove Change-Id: line (Gerrit-specific, not for kernel trees)
  2. Missing prefix — Add QCLINUX: (or FROMLIST: if posted upstream) to commit subject
  3. Unrelated changes — Remove or split out the "Bibek" model string changes

2 warnings to address:

  • Fix Co-Authored-By: → Co-authored-by: (lowercase)
  • Ensure the model string changes are intentional and properly documented

@bibekpatro Bibek Kumar Patro (bibekpatro) changed the title arm64: dts: qcom: shikra: Add OP-TEE node and disable unused CTI arm64: dts: qcom: shikra: disable unused CTI Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants