Skip to content

arm64: dts: hamoa: optimize PCIe bandwidth voting and power requirements for Gen1/Gen2 x1 links - #1228

Closed
abhi6246-OSS wants to merge 0 commit into
qualcomm-linux:qcom-6.18.yfrom
abhi6246-OSS:qcom-6.18.y
Closed

abhi6246-OSS wants to merge 0 commit into
qualcomm-linux:qcom-6.18.yfrom
abhi6246-OSS:qcom-6.18.y

Conversation

@abhi6246-OSS

Copy link
Copy Markdown

Update the PCIe device tree configuration to reduce power requirements and align interconnect bandwidth voting tags with the latest RPMh-based definitions.

Replace legacy interconnect tags:

QCOM_ICC_TAG_ALWAYS → RPM_ALWAYS_TAG
QCOM_ICC_TAG_ACTIVE_ONLY → RPM_ACTIVE_TAG

Reduce PCIe power-domain requirements for Gen1 and Gen2 x1 operating points:

Change required-opps from rpmpd_opp_nom to rpmpd_opp_low_svs
Applied to:
opp-2500000 (Gen1 x1)
opp-5000000 (Gen2 x1)

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1228 — validate-patch

PR: #1228

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: Unknown — cannot check without pr.patch
  2. Lore link matches PR commits: N/A — no commits to validate
  3. Upstream patch status: N/A — no patch content available
  4. PR present in qcom-next/topics: Fail - pr.patch is missing

Validation cannot proceed until pr.patch is available.

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1228 (qualcomm-linux/kernel)
Upstream commit: N/A
Verdict: ❌ FAIL

Reason

The PR patch file (pr.patch) is missing or empty. This is a critical failure that prevents any validation from being performed.

According to the lore evidence status:

status: failed
reason: pr.patch is missing or empty

According to the integration presence report:

Status: FAIL - pr.patch is missing

Root Cause Analysis

This failure indicates one of the following scenarios:

  1. Empty PR: The PR contains no commits (closed/merged without changes)
  2. Patch extraction failure: The GitHub API or gh pr diff command failed to extract the diff
  3. Workflow error: The upstream Jarvis workflow that prepares validation inputs encountered an error before invoking this agent

Recommendation

Cannot proceed with validation. The PR must contain at least one commit with a valid diff for the validate-patch skill to analyze.

Required actions:

  1. Verify that PR arm64: dts: hamoa: optimize PCIe bandwidth voting and power requirements for Gen1/Gen2 x1 links #1228 exists and contains commits at arm64: dts: hamoa: optimize PCIe bandwidth voting and power requirements for Gen1/Gen2 x1 links #1228
  2. If the PR was closed/merged, this validation run is stale and should be ignored
  3. If the PR is open with commits, re-trigger the kernel-checker workflow to regenerate pr.patch
  4. Check the Jarvis orchestrator logs for patch extraction errors

Final Summary

  1. Lore link present: Unknown — cannot check without pr.patch
  2. Lore link matches PR commits: N/A — no commits to validate
  3. Upstream patch status: N/A — no patch content available
  4. PR present in qcom-next/topics: FAIL — integration presence check could not run (pr.patch missing)

Validation cannot proceed until pr.patch is available.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Status: FAIL - pr.patch is missing

@qlijarvis

Copy link
Copy Markdown

PR #1228 — checker-log-analyzer

PR: #1228
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/36868229271

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 error, 1 warning: missing Signed-off-by, missing commit description
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Subject line missing required prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1228 — shikra upadted tag value in dts
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/36868229271
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 1 error, 1 warning: missing Signed-off-by, missing commit description
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Subject line missing required prefix (mandatory for qcom-6.18.y)

❌ checkpatch

Root cause: Commit 2d232a6f6390 is missing mandatory commit metadata (Signed-off-by trailer and commit description).

Failure details:

Commit 2d232a6f6390 ("shikra upadted tag value in dts")
WARNING: Missing commit description - Add an appropriate one
ERROR: Missing Signed-off-by: line(s)
2d232a6f6390d65a20516c6dd8e02906692240bd total: 1 errors, 1 warnings, 0 checks, 30 lines checked

Fix:

git rebase -i 110eabaa857a   # mark commit as 'edit'
git commit --amend
# In the editor:
# 1. Fix the subject typo: "shikra upadted tag value in dts" → "shikra: Update tag value in DTS"
# 2. Add a commit body describing what tag values were changed and why
# 3. Add "Signed-off-by: Your Name <your.email@example.com>" at the end
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 110eabaa857a..2d232a6f6390

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: shikra upadted tag value in dts
Commit summary does not start with a required prefix

Fix:

The commit subject must start with one of the allowed prefixes. Choose based on the patch origin:

Prefix When to use
FROMLIST: Patch posted to lore.kernel.org but not yet merged
FROMGIT: Patch taken from a maintainer git tree
UPSTREAM: Patch merged into Linus's mainline tree
BACKPORT: Upstream patch backported with modifications

If this is a vendor-only DTS change with no upstream equivalent, use QCLINUX: — but note that check-patch-compliance will still fail (known checker limitation for vendor-only commits).

git rebase -i 110eabaa857a   # mark commit as 'edit'
# If posted upstream:
git commit --amend -m "FROMLIST: arm64: dts: qcom: shikra: Update tag value"
# OR if vendor-only:
git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Update tag value"
git rebase --continue

If using FROMLIST:, also add a Link: trailer pointing to the lore.kernel.org URL in the commit body.


❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must start with a valid prefix tag. Commit 2d232a6f6390 ("shikra upadted tag value in dts") has no prefix.

Failure details:

Commit 2d232a6f6390 ("shikra upadted tag value in dts"): subject line does not start with a required prefix.
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix:

Add the appropriate prefix to the commit subject:

git rebase -i 110eabaa857a   # mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: shikra: Update tag value"
# OR
git commit --amend -m "QCLINUX: arm64: dts: qcom: shikra: Update tag value"
git rebase --continue

Choose the correct prefix based on the patch origin:

  • Posted to lore but not yet merged → FROMLIST:
  • In a maintainer tree → FROMGIT:
  • Merged into Linus's tree → UPSTREAM:
  • Backported with modifications → BACKPORT:
  • Vendor-only, no upstream → QCLINUX:

Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Add Signed-off-by: trailer and commit description
  2. check-patch-compliance — Add required subject prefix (FROMLIST:, UPSTREAM:, BACKPORT:, or QCLINUX:)
  3. tag-check — Same as Adding Email Checker  #2 (subject prefix is mandatory for qcom-6.18.y branch)

Recommended combined fix:

git rebase -i 110eabaa857a   # mark commit 2d232a6f6390 as 'edit'
git commit --amend

In the editor, rewrite the commit message to:

FROMLIST: arm64: dts: qcom: shikra: Update tag value

Update the tag values in shikra.dtsi from X to Y to [explain why].

Link: https://lore.kernel.org/... (if posted upstream)
Signed-off-by: Your Name <your.email@example.com>

Then:

git rebase --continue
git push --force-with-lease

@qlijarvis

Copy link
Copy Markdown

PR #1228 — validate-patch

PR: #1228

Verdict Issues Detailed Report
❌ 5 Full report

Final Summary

  1. Lore link present: Unknown - cannot parse commit messages from missing pr.patch
  2. Lore link matches PR commits: N/A - no patch content to compare
  3. Upstream patch status: Unknown - cannot determine without commit messages and lore links
  4. PR present in qcom-next/topics: Fail - pr.patch is missing

Overall status: ❌ VALIDATION BLOCKED - Missing pr.patch prevents all validation steps from executing.

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1228 (qualcomm-linux/kernel)
Upstream commit: N/A (cannot determine - pr.patch missing)
Verdict: ❌ FAIL

Reason

Critical infrastructure failure: The PR patch file (pr.patch) is missing or empty. This prevents all validation steps from executing.

According to the evidence:

  • lore_evidence/README.md: "status: failed, reason: pr.patch is missing or empty"
  • integration_presence_report.md: "Status: FAIL - pr.patch is missing"

Without the patch content, the validate-patch skill cannot:

  1. Extract commit messages to search for lore.kernel.org links
  2. Identify changed files
  3. Compare PR diff against upstream lore patches
  4. Verify commit message correctness
  5. Check authorship and tag hygiene
  6. Determine integration presence in qcom-next/topics

Commit Message

Check Status Note
Subject matches upstream ⏭️ Skipped pr.patch missing
Body preserves rationale ⏭️ Skipped pr.patch missing
Fixes tag present/correct ⏭️ Skipped pr.patch missing
Authorship preserved ⏭️ Skipped pr.patch missing
Backport note (if applicable) ⏭️ Skipped pr.patch missing

Diff

File Status Notes
(none) ❌ FAIL pr.patch is empty - no files to validate

Issues

Blocker:

  • pr.patch is missing or empty - The patch file that should contain the PR diff is not present or has zero bytes. This is a prerequisite for all validation steps.

Root cause: The PR patch collection step failed during the Jarvis pre-processing phase (see checker_summary.txt line: "Collecting PR patch (background)"). This may indicate:

Verdict

Cannot validate - The validation workflow cannot proceed without the PR patch content. This must be resolved before any patch validation can occur.

Recommendation

Immediate action required:

  1. Verify that PR arm64: dts: hamoa: optimize PCIe bandwidth voting and power requirements for Gen1/Gen2 x1 links #1228 exists and is accessible at arm64: dts: hamoa: optimize PCIe bandwidth voting and power requirements for Gen1/Gen2 x1 links #1228
  2. Re-run the Jarvis collection step to fetch pr.patch:
    gh pr diff 1228 --repo qualcomm-linux/kernel > pr.patch
  3. If the PR is closed/merged, specify the commit SHA range instead
  4. Once pr.patch is populated, re-run the validate-patch skill

Final Summary

  1. Lore link present: Unknown - cannot parse commit messages from missing pr.patch
  2. Lore link matches PR commits: N/A - no patch content to compare
  3. Upstream patch status: Unknown - cannot determine without commit messages and lore links
  4. PR present in qcom-next/topics: FAIL - integration_presence_report.md reports "pr.patch is missing"

Overall status: ❌ VALIDATION BLOCKED - Missing pr.patch prevents all validation steps from executing.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Status: FAIL - pr.patch is missing

@qlijarvis

Copy link
Copy Markdown

PR #1228 — checker-log-analyzer

PR: #1228
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/36969701953

Checker Result Summary
Checker Result Summary
checkpatch ❌ 5 commits with style issues: missing Signed-off-by, missing commit description, non-standard signatures, missing Closes: tag
dt-binding-check ⏭️ No DT binding changes
dtb-check ✅ All DTB validations passed
sparse-check ✅ No sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ All 5 commits missing required subject prefix
tag-check ❌ All 5 commits missing required subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1228 - shikra upadted tag value in dts (+ 4 more commits)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/36969701953
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 5 commits with style issues: missing Signed-off-by, missing commit description, non-standard signatures, missing Closes: tag
dt-binding-check ⏭️ No DT binding changes
dtb-check ✅ All DTB validations passed
sparse-check ✅ No sparse warnings
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ All 5 commits missing required subject prefix
tag-check ❌ All 5 commits missing required subject prefix (mandatory for qcom-6.18.y)

❌ checkpatch

Root cause: Multiple commits have formatting and metadata issues including missing Signed-off-by, missing commit description, non-standard signature tags, and missing Closes: tag.

Failure details:

Commit 2d232a6 ("shikra upadted tag value in dts"):

WARNING: Missing commit description - Add an appropriate one
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 1 warnings, 0 checks, 30 lines checked

Commits acb5a68, bb6acc4, 3fed769 (genirq/PCI commits):

WARNING: Non-standard signature: Originally-by:

Commit 05acecd ("genirq: Update effective affinity for redirected interrupts"):

WARNING: Unknown commit id 'fcc1d0dabdb6', maybe rebased or not pulled?
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
total: 0 errors, 2 warnings, 0 checks, 8 lines checked

Fix:

For commit 2d232a6f6390:

git rebase -i <base_sha>   # mark commit as 'edit'
# Add a proper commit description explaining what changed and why
# Add Signed-off-by: Your Name <your.email@example.com>
git commit --amend
git rebase --continue

For commits with Originally-by: tags (acb5a68, bb6acc4, 3fed769):

  • Originally-by: is not a standard kernel tag. Replace with standard tags:
    • Use From: if the original author should be credited
    • Use Suggested-by: if someone suggested the approach
    • Or remove if not needed

For commit 05acecdd7236:

  • Add Closes: tag immediately after Reported-by: with a URL to the bug report
  • The "Unknown commit id" warning can be ignored if the commit is from another tree

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..<head>

❌ check-patch-compliance

Root cause: All 5 commits are missing the required subject-line prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: shikra upadted tag value in dts
Commit summary does not start with a required prefix

Checking commit: genirq: Add interrupt redirection infrastructure
Commit summary does not start with a required prefix

Checking commit: PCI: dwc: Code cleanup
Commit summary does not start with a required prefix

Checking commit: PCI: dwc: Enable MSI affinity support
Commit summary does not start with a required prefix

Checking commit: genirq: Update effective affinity for redirected interrupts
Commit summary does not start with a required prefix

Fix:

Each commit subject must start with one of the required prefixes. Choose based on the patch origin:

Prefix When to use
FROMLIST: Patch posted to lore.kernel.org but not yet merged
FROMGIT: Patch taken from a maintainer git tree
UPSTREAM: Patch merged into Linus's mainline tree
BACKPORT: Upstream patch backported with modifications
QCLINUX: Vendor-only change (but note: this will still fail check-patch-compliance)

Example fix for the first commit:

git rebase -i <base_sha>   # mark commit as 'reword'
# Change subject from:
#   shikra upadted tag value in dts
# To:
#   QCLINUX: arm64: dts: qcom: shikra: Update tag value

For the genirq/PCI commits, if they are from upstream or posted upstream, use the appropriate prefix and add a Link: tag pointing to the lore.kernel.org URL.

Reproduce locally:

# Check each commit subject manually
git log <base>..<head> --format="%H %s"

❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must have a subject-line prefix. All 5 commits are missing this required prefix.

Failure details:

All commits fail the prefix check:

  • 2d232a6f6390 - "shikra upadted tag value in dts" → no prefix
  • acb5a68aa184 - "genirq: Add interrupt redirection infrastructure" → no prefix
  • bb6acc4ca50d - "PCI: dwc: Code cleanup" → no prefix
  • 3fed769b13d7 - "PCI: dwc: Enable MSI affinity support" → no prefix
  • 05acecdd7236 - "genirq: Update effective affinity for redirected interrupts" → no prefix

Fix:

Add one of the required prefixes to every commit subject:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:
git rebase -i <base_sha>
# Mark each commit as 'reword'
# Add the appropriate prefix to each subject line

Note: The tag-check and check-patch-compliance failures are related. However, check-patch-compliance only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), while tag-check also accepts vendor-only prefixes (QCLINUX:, PENDING:, WORKAROUND:). If you use QCLINUX: or PENDING:, the check-patch-compliance checker will still fail, but that's a known limitation for vendor-only commits.

Reproduce locally:

git log <base>..<head> --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix: $sha $subject"
  fi
done

Verdict

5 blockers must be fixed before merge:

  1. Commit 2d232a6 - Add commit description and Signed-off-by (ERROR)
  2. All 5 commits - Add required subject-line prefix (FROMLIST:/UPSTREAM:/QCLINUX: etc.)
  3. Commits acb5a68, bb6acc4, 3fed769 - Replace non-standard Originally-by: tag
  4. Commit 05acecd - Add Closes: tag after Reported-by:
  5. First commit subject - Fix typo: "upadted" → "updated"

The most critical issues are:

  • Missing Signed-off-by: on commit 2d232a6 (ERROR - blocks merge)
  • Missing subject prefixes on all commits (required for qcom-6.18.y branch)

All other checkers (dt-binding-check, dtb-check, sparse-check, check-uapi-headers) passed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants