Add "Events" page - #280
Merged
Merged
Conversation
…eprocessing of iCal to a function and added a test for it, fixed some typos, renamed feeds file and other small fixes
…ception in case of an error
Closes #96 forever
honzajavorek
force-pushed
the
honzajavorek/events
branch
from
September 15, 2018 21:10
3c4011c to
7c2b65d
Compare
Member
Author
|
One note, I'd prefer to merge this if you think it's good enough and to file additional issues afterwards so we can iteratively improve this. I don't think I can spend much more time improving this particular PR in following days / weeks. |
This was referenced Sep 15, 2018
Member
|
Questions:
|
hroncok
approved these changes
Sep 16, 2018
Member
Author
|
Some of it was a bug in template I fixed in in following commit (I hope I
pushed it), some of it is
pyvec/pyvo.cz#103
…On Sun, 16 Sep 2018 at 11:05, Miro Hrončok ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#280 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARTMdaYGas504KaiDZxnEueiptDlV1Jks5ubhRTgaJpZM4Wqivh>
.
|
Member
|
no commit here |
Contributor
|
I've added URLs to pyworking workshops ical export (https://pyworking.cz/workshops.ics) |
mikicz
approved these changes
Sep 16, 2018
Member
Author
Member
Author
|
Thank you all! Merging, hopefully everything's gonna be pretty much all right 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of and closes #268 ❤️ @mikicz
Also closes #220 (the original ticket)
INDEX PAGE
EVENTS PAGE