Repository navigation
fix: add a version resolution for cookie in react native llama example app and use yarn as the package manager - #7218
Merged
facebook-github-bot merged 1 commit intoDec 6, 2024
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7218
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 70b211e with merge base 63238ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
shoumikhin
approved these changes
Dec 6, 2024
Contributor
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Hi @hietalajulius could you please update all packages to latest? Specifically, undici in deps to 6.21.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #7134 (comment)
TL;DR:
remix-run/server-runtime(which is a downstream dependency of the example react native app), depends oncookie(version^0.6.0) which has a vulnerability prior to0.7.0, this PR adds a resolution to>=0.7.0. Also switches to usingyarninstead ofnpm.Test plan
before resolution
after resolution