Skip to content

Qualcomm AI Engine Direct - Fix fp16 unit test - #22059

Merged
psiddh merged 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/chenweng/fix_fp16_ut
Aug 23, 2026
Merged

Qualcomm AI Engine Direct - Fix fp16 unit test#22059
psiddh merged 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/chenweng/fix_fp16_ut

Conversation

@chenweng-quic

@chenweng-quic chenweng-quic commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Since nn.Module has no graph, the fp16 unit test failed with error "AttributeError: object has no attribute 'graph'".
#21729 introduce the error. Per internal discussion, we don't want to extend the function to include everything.
Considering the pass already ensure the hadamard transform op exist, we will revert the change to add expected_target.

Test plan

pytest backends/qualcomm/tests/rework/htp/op/v68/test.py

@pytorch-bot

pytorch-bot Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22059

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b082ba8 with merge base cff6f4d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2026
@chenweng-quic
Qualcomm AI Engine Direct - Fix fp16 unit test
b082ba8 
Revert change introduced in pytorch#21729. Per internal discussion, we don't
want to extend the function to include everything. Considering the pass
already ensure the hadamard transform op exist, we will revert the op
e2e test function.
@chenweng-quic
chenweng-quic force-pushed the dev1/chenweng/fix_fp16_ut branch from b200d82 to b082ba8 Compare August 23, 2026 03:14
@github-actions

github-actions Bot commented Aug 23, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh
psiddh merged commit b8b5e0f into pytorch:main Aug 23, 2026
176 checks passed
@chenweng-quic
chenweng-quic deleted the dev1/chenweng/fix_fp16_ut branch August 24, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psiddh psiddh psiddh approved these changes
@abhinaykukkadapu abhinaykukkadapu Awaiting requested review from abhinaykukkadapu

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenweng-quic @psiddh