Third-party tests failed on Thu Dec 05 2024 #513

Activity

1. brianschubert commented on Dec 5, 2024

   

   brianschubert

   on Dec 5, 2024

   Last edited by brianschubert

   Contributor

   More actions

   https://github.com/python/typing_extensions/actions/runs/12172317648/job/33950775320

   typed-argument-parser tests are failing on 3.13:

   =========================== short test summary info ============================
   FAILED tests/test_to_tap_class.py::test_subclasser_subparser[function-args_string_and_arg_to_expected_value7] - assert "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" in "usage: pytest [--foo] --arg_int ARG_INT [--arg_bool]\n              [--arg_list [ARG_LIST ...]] [-h]\n              {a,b} ...\npytest: error: argument {a,b}: invalid choice: 'X' (choose from a, b)\n"
    +  where "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" = str(SystemExit("error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')"))
   FAILED tests/test_to_tap_class.py::test_subclasser_subparser[Class-args_string_and_arg_to_expected_value7] - assert "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" in "usage: pytest [--foo] --arg_int ARG_INT [--arg_bool]\n              [--arg_list [ARG_LIST ...]] [-h]\n              {a,b} ...\npytest: error: argument {a,b}: invalid choice: 'X' (choose from a, b)\n"
    +  where "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" = str(SystemExit("error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')"))
   FAILED tests/test_to_tap_class.py::test_subclasser_subparser[_Args-args_string_and_arg_to_expected_value7] - assert "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" in "usage: pytest [--foo] --arg_int ARG_INT [--arg_bool]\n              [--arg_list [ARG_LIST ...]] [-h]\n              {a,b} ...\npytest: error: argument {a,b}: invalid choice: 'X' (choose from a, b)\n"
    +  where "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" = str(SystemExit("error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')"))
   FAILED tests/test_to_tap_class.py::test_subclasser_subparser[class_or_function_3-args_string_and_arg_to_expected_value7] - assert "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" in "usage: pytest [--foo] --arg_int ARG_INT [--arg_bool]\n              [--arg_list [ARG_LIST ...]] [-h]\n              {a,b} ...\npytest: error: argument {a,b}: invalid choice: 'X' (choose from a, b)\n"
    +  where "error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')" = str(SystemExit("error: argument {a,b}: invalid choice: 'X' (choose from 'a', 'b')"))
   ======================== 4 failed, 301 passed in 1.58s =========================
   
2. JelleZijlstra commented on Dec 5, 2024

   

   JelleZijlstra

   on Dec 5, 2024

   Member

   More actions

   Likely related to argparse changes in 3.13.1?

   👍React with 👍1Reacted by Alex Waygood
3. AlexWaygood commented on Dec 5, 2024

   

   AlexWaygood

   on Dec 5, 2024

   Member

   More actions

   If we need to we should skip TAP tests on 3.13 for now in this workflow until it's fixed upstream

   👍React with 👍1Reacted by Jelle Zijlstra
4. brianschubert commented on Dec 5, 2024

   

   brianschubert

   on Dec 5, 2024

   Contributor

   More actions

   Looks like a consequence of python/cpython#117766, which changed how the choices are displayed in the error message (switched from repr to str). That PR was also backported to 3.12.8, so we should probably skip the TAP tests on 3.12 as well if we go that route (we didn't see failures this time since the runner was still using 3.12.7).
5. JelleZijlstra commented on Dec 5, 2024

   

   JelleZijlstra

   on Dec 5, 2024

   Member

   More actions

   @brianschubert thanks! Would you mind mentioning that on the issue I opened (linked above) on the typed-argument-parser repo? Perhaps they'll be able to fix it quickly. If not, I can send a PR later today to disable the tests here.

   👍React with 👍1Reacted by Brian Schubert
6. JelleZijlstra commented on Dec 6, 2024

   

   JelleZijlstra

   on Dec 6, 2024

   Member

   More actions

   Fixed in #515 (where I put the wrong number)

   😄React with 😄1Reacted by Alex Waygood
7. JelleZijlstra

   closed this as completedon Dec 6, 2024