Repository navigation
Add support for Python 3.8 in typing_extensions - #647
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #643
(Use ignore whitespace option to review this, since it mostly just indents a bunch of stuff.)
PR summary:
typingtests on Python 3.6 or older, starting from Python 3.7 development oftypingmoved to CPython repo, where it was significantly reworked. We still runtyping_extensiontests on all versions.repr()tests intyping_extensionsto conditionally expect correct module name.TypedDictto__all__.Final,Literal, etc. fromtypingif those are available (as we do for other things).@runtimeto@runtime_checkableintyping_extensions(I think we can keep@runtimeintyping_extensionsas an alias for backwards compatibility).Note this only updates Python 3 version of
typing_extensions. There will be a corresponding update for the Python 2 version oftyping_extensionsas part of #648