Skip to content

Add support for Python 3.8 in typing_extensions - #647

Merged
ilevkivskyi merged 15 commits into
python:masterfrom
ilevkivskyi:update-extensions
Jun 16, 2019
Merged

ilevkivskyi merged 15 commits into
python:masterfrom
ilevkivskyi:update-extensions

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Jun 16, 2019 •

Copy link
Copy Markdown
Member

Fixes #643

(Use ignore whitespace option to review this, since it mostly just indents a bunch of stuff.)

PR summary:

  • Update Travis config to run on a bunch of newer Python versions (including 3.8-dev).
  • Only run typing tests on Python 3.6 or older, starting from Python 3.7 development of typing moved to CPython repo, where it was significantly reworked. We still run typing_extension tests on all versions.
  • Update repr() tests in typing_extensions to conditionally expect correct module name.
  • Add TypedDict to __all__.
  • Use Final, Literal, etc. from typing if those are available (as we do for other things).
  • Rename @runtime to @runtime_checkable in typing_extensions (I think we can keep @runtime in typing_extensions as an alias for backwards compatibility).

Note this only updates Python 3 version of typing_extensions. There will be a corresponding update for the Python 2 version of typing_extensions as part of #648

@ilevkivskyi ilevkivskyi changed the title Add support for Python 3.8 Add support for Python 3.8 in typing_extensions Jun 16, 2019
@ilevkivskyi
ilevkivskyi requested a review from gvanrossum June 16, 2019 02:10

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@ilevkivskyi
ilevkivskyi merged commit 20d1f1b into python:master Jun 16, 2019
@ilevkivskyi
ilevkivskyi deleted the update-extensions branch June 16, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python-typing-extensions fails to build with Python 3.8

3 participants