PEP 612 support #794

Activity

1. JelleZijlstra commented on Apr 4, 2021

   

   JelleZijlstra

   on Apr 4, 2021

   Member

   More actions

   There is an open pull request: #774.

   ❤️React with ❤️1Reacted by Mark Edwards
2. markedwards commented on Apr 4, 2021

   

   markedwards

   on Apr 4, 2021

   Author

   More actions

   Thanks for the pointer @JelleZijlstra
3. gvanrossum commented on Apr 5, 2021

   

   gvanrossum

   on Apr 5, 2021 via email

   Member

   More actions

   @JelleZijlstra could you review #774?

   …

   On Sun, Apr 4, 2021 at 2:16 PM markedwards ***@***.***> wrote: Thanks for the pointer @JelleZijlstra <https://github.com/JelleZijlstra> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#794 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWCWMSAJZDECTQB3BJIUVLTHDJMRANCNFSM42LTXK6A> .

   -- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-change-the-world/>
4. JelleZijlstra commented on Apr 5, 2021

   

   JelleZijlstra

   on Apr 5, 2021

   Member

   More actions

   I will, I can ping you once I'm happy with it.
5. JelleZijlstra commented on Apr 11, 2021

   

   JelleZijlstra

   on Apr 11, 2021

   Member

   More actions

   This has now been merged.
6. JelleZijlstra

   closed this as completedon Apr 11, 2021
7. markedwards commented on Apr 11, 2021

   

   markedwards

   on Apr 11, 2021

   Author

   More actions

   Thanks!
8. markedwards commented on Oct 23, 2021

   

   markedwards

   on Oct 23, 2021

   Last edited by markedwards

   Author

   More actions

   Following up on this, running mypy 0.910 and typing-extensions 3.10.0.2, I get errors with the documentation example for ParamSpec:

   import logging
   from collections.abc import Callable
   from typing import TypeVar
   
   from typing_extensions import ParamSpec
   
   T = TypeVar('T')
   P = ParamSpec('P')
   
   
   def add_logging(f: Callable[P, T]) -> Callable[P, T]:
   # mypy complains for the above line:
   #     The first argument to Callable must be a list of types or "..."
   
       def inner(*args: P.args, **kwargs: P.kwargs) -> T:
       # mypy complains for the above line:
       #     Name "P.args" is not defined
       #     Name "P.kwargs" is not defined
           logging.info(f'{f.__name__} was called')
           return f(*args, **kwargs)
       return inner

   Is it not possible to use ParamSpec in python 3.9?
9. srittau commented on Oct 23, 2021

   

   srittau

   on Oct 23, 2021

   Collaborator

   More actions

   mypy 0.910 doesn't support ParamSpec yet.

   👍React with 👍1Reacted by Mark Edwards
10. markedwards commented on Oct 23, 2021

    

    markedwards

    on Oct 23, 2021

    Author

    More actions

    @srittau Thanks, I see python/mypy#8645 now