Repository navigation
Change ignore_missing_stub default to false - #9779
Conversation
|
|
||
| Many third-party stubs packages in typeshed are currently incomplete, and so by | ||
| default, `stubtest_third_party.py` runs stubtest with the | ||
| Most third-party stubs packages in typeshed are currently complete (as far as stubtest is |
There was a problem hiding this comment.
Github won't let me leave a suggestion, but I'd replace this paragraph with something like:
If a distribution has
ignore_missing_stub = truein the
tool.stubtestsection of itstests/METADATA.tomlfile,stubtest_third_party.pywill test that distribution with the--ignore-missing-stuboption. This indicates that the stubs for this distribution are considered "incomplete".
There was a problem hiding this comment.
A lot less verbose, I like it. Would you keep the example?
Yeah it'll break typeshed-stats, but it's not hard to unbreak :) the implementation's here, if you're curious: https://github.com/AlexWaygood/typeshed-stats/blob/main/src/typeshed_stats/gather.py#L406 |
|
Fixed the |
Closes #9538 which got lots of thumbs up, and hopefully I'm not misinterpreting @hauntsaninja 's comment in python/mypy#14692 (comment) saying he advocated against
--ignore-missing-stubby default.I wanted to wait until after mypy 1.0 (with its many stubtest fixes) for this. Should help promote complete stubs.
CC @AlexWaygood because this affects typeshed-stats (unless it reuses
parse_metadata.py, idk how you implemented it)