Repository navigation
Improve builtins.vars() - #9146
Merged
Merged
Conversation
AlexWaygood
commented
Nov 10, 2022
AlexWaygood
commented
Member
```pycon
>>> class Foo: ...
...
>>> vars(Foo)
mappingproxy({'__module__': '__main__', '__dict__': <attribute '__dict__' of 'Foo' objects>, '__weakref__': <attribute '__weakref__' of 'Foo' objects>, '__doc__': None})
```
AlexWaygood
commented
Nov 10, 2022
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
marked this pull request as ready for review
November 10, 2022 11:01
srittau
approved these changes
Nov 10, 2022
JelleZijlstra
pushed a commit
to python/mypy
that referenced
this pull request
Mar 8, 2023
The `stubtest.py` cast is no longer needed -- I think the mypyc issue was fixed by python/typeshed#9146. The `types.py` casts were never needed. They were added relatively recently by somebody called "Alex Waygood".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.