Skip to content

Revert "Use Callable[..., Any] instead of Callable[..., object] in unittest" - #8779

Merged
srittau merged 5 commits into
mainfrom
revert-8399-fix-8372-unittest
Nov 10, 2023
Merged

srittau merged 5 commits into
mainfrom
revert-8399-fix-8372-unittest

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Sep 21, 2022 •

Copy link
Copy Markdown
Member

DO NOT merge this until python/mypy#13220 is fixed.

Reverts #8373 and #8399.

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Sep 21, 2022
@github-actions

This comment has been minimized.

@AlexWaygood
AlexWaygood marked this pull request as draft September 21, 2022 12:56
@github-actions

This comment has been minimized.

@srittau

srittau commented Sep 21, 2022

Copy link
Copy Markdown
Collaborator

Thanks!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexWaygood

Copy link
Copy Markdown
Member Author

DO NOT merge this until python/mypy#13220 is fixed.

The issue was fixed, and the fix (python/mypy@5f6961b) was included in mypy 1.7. This PR can now (finally!) be merged.

@AlexWaygood
AlexWaygood marked this pull request as ready for review November 10, 2023 18:44
@AlexWaygood AlexWaygood removed the status: deferred Issue or PR deferred until some precondition is fixed label Nov 10, 2023
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
srittau merged commit eebc287 into main Nov 10, 2023
@srittau
srittau deleted the revert-8399-fix-8372-unittest branch November 10, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants