Repository navigation
Improve classes returned from OrderedDict.{keys(), items(), values()} - #8552
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Ping, @sobolevn -- I'd be interested to hear your thoughts on this :) |
sobolevn
approved these changes
Aug 20, 2022
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
I think that we can still keep _OrderedDict* classes, but I am pretty sure that nobody will miss them 😆
Member
Author
Ugh, I guess you're right, somebody somewhere is probably relying on them being in the stub 😆 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sobolevn
approved these changes
Aug 20, 2022
Member
Author
|
Thanks for the review @sobolevn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative PR to #8544 (closes #8544). @sobolevn, what do you think? :)