[kkirsche]

The metaclasses are typed to match the following type.__init__ overload:
https://github.com/python/typeshed/blob/master/stdlib/builtins.pyi#L167

As query's are generic in SQLAlchemy, this begins to make Model generic for use in the flask_sqlalchemy.__init__ file once this is completed.

This also updates __table_cls__ from NameMetaMixin. This returns a table from:

1. https://github.com/pallets-eco/flask-sqlalchemy/blob/main/src/flask_sqlalchemy/model.py#L78
2. https://github.com/pallets-eco/flask-sqlalchemy/blob/main/src/flask_sqlalchemy/model.py#L86
3. https://github.com/pallets-eco/flask-sqlalchemy/blob/main/src/flask_sqlalchemy/model.py#L94

and then has a None return if this branch hits:
https://github.com/pallets-eco/flask-sqlalchemy/blob/main/src/flask_sqlalchemy/model.py#L90-L92

and the code runs to completion.

[kkirsche]

I wasn't sure if this should be Generic[_Model] or if I should be using Query[Self] instead to indicate that it's the current model

[AlexWaygood]

@srittau, does making Model generic look correct to you?

[kkirsche]

Class implementation can be seen here, if it helps:
https://github.com/pallets-eco/flask-sqlalchemy/blob/main/src/flask_sqlalchemy/model.py#L115

[srittau]

I have no experience with flask-sqlalchemy, but considering that sqlalchemy.orm.query is generic: probably.

[AlexWaygood]

Let's YOLO it then. If it causes a problem for somebody, we'll know soon enough.

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉